Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onepage/billing.phtml required still displayed after removed. #3902

Open
f1-outsourcing opened this issue Mar 25, 2024 · 3 comments
Open

onepage/billing.phtml required still displayed after removed. #3902

f1-outsourcing opened this issue Mar 25, 2024 · 3 comments

Comments

@f1-outsourcing
Copy link
Contributor

f1-outsourcing commented Mar 25, 2024

rwd/default/template/persistent/checkout/onepage/billing.phtml

I think something weird is happening at this line, still prints 'required' stars, after removing "*" and the required class

this code

     96                 <li class="fields">
     97                     <div class="field">
     98                         <label for="billing:postcode">+++<?php echo $this->__('Zip/Postal Code'); ?>---</label>
     99                         <div class="input-box">

generates this output on the website.
checkout

<label for="billing:postcode" class="required">+++Zip/Postal Code--- <span class="required">*</span></label>

I already restarted apache and php-fpm, does not look like a caching issue. If I add/remove '+++' and '---', the changes are directly visible.

v20.5.0.

@f1-outsourcing
Copy link
Contributor Author

f1-outsourcing commented Mar 26, 2024

Looks like this onepage checkout is a bit buggy anyway. After setting is_required to 0, you still get popups "Please enter the telephone number."

https://stackoverflow.com/questions/5456794/magento-make-the-field-company-required

php -d disable_functions=none -d apc.enable_cli=1 ../n98-magerun.phar mysql-client

UPDATE eav_attribute SET is_required = 0 WHERE attribute_code = 'telephone';

@addison74
Copy link
Contributor

This issue is not following the report format. Please provide all steps to reproduce it.

@f1-outsourcing
Copy link
Contributor Author

f1-outsourcing commented Mar 26, 2024

if I change the label to billing:postcode2, the required is gone, so something is injecting it. Maybe this file was being updated from where the * where hardcoded to where functions would do this on the basis of some configuration somewhere, and they started 'testing' this with postalcode?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants