Possible Global Record Search Improvement

[seansan]

Possible Global Record Search Improvement

• If searching for full order increment_id and only 1 match: the redirect directly to order view page

• change order increment_id search to "%search_string" search from right because we often only enter the last XX digits

[colinmollenhour]

Global search becomes totally unusable once you have a large order history. If anything it should only use prefix matches so that indexes may be used since when you use a suffix match a full table scan is required. With prefix matches or exact matches only the performance is pretty acceptable.

[seansan]

This is partly so. For us the solution was to re-think the usage. We dont use it to find customers (we can do that via orders) and we did not use it to find products.

As a result we

• disabled customer and product search: it is only orders
• we reduced results set to 5
• added logic to the search query: number = order id
• only search for billing lastname (If text)
• add order_by (it is logic that it is often a recent order calling)
• Fix description to add the correct CustomerName + add the order date to the string
• Changed mathcing logic (lastname = always first letters, order id is always last numbers)
• Todo: implement when only 1 search result goto order redirect. UPDATE, found the trick: set 'autoSelect:true,' in new Ajax.Autocompleter('global_search',

A lot is lost here. But also a lot is gained => because it is now being used again. And it is now very fast

My reasoning is. If nobody uses it. Then strip it to basics. And start adding logic that people do use!

Hope it helps someone

     * Load search results
     *
     * @return Mage_Adminhtml_Model_Search_Order
     */
    public function load()
    {
        $arr = array();

        if (!$this->hasStart() || !$this->hasLimit() || !$this->hasQuery()) {
            $this->setResults($arr);
            return $this;
        }

        $query = trim($this->getQuery());

        $search_array = array();
        if (is_numeric($query)) {
            $search_array[] = array('attribute' => 'increment_id', 'like'=>'%'.$query);
        } else {
            $search_array[] = array('attribute' => 'billing_lastname', 'like'=>$query.'%');
        }

        $collection = Mage::getResourceModel('sales/order_collection')
            ->addAttributeToSelect('*')
            ->addAttributeToSearchFilter($search_array)
            ->setCurPage($this->getStart())
            ->setPageSize($this->getLimit())
            ->setOrder('entity_id')
            ->load();

        foreach ($collection as $order) {
            $date = Mage::getModel('core/date')->date('d M Y', strtotime($order->getCreatedAt()));
            $arr[] = array(
                'id'                => 'order/1/'.$order->getId(),
                'type'              => Mage::helper('adminhtml')->__('Order'),
                'name'              => Mage::helper('adminhtml')->__("Order #%s", $order->getIncrementId()),
                'description'       => $order->getCustomerName() . " - $date",
                'form_panel_title'  => Mage::helper('adminhtml')->__('Order #%s (%s)', $order->getIncrementId(), $order->getBillingFirstname().' '.$order->getBillingLastname()),
                'url' => Mage::helper('adminhtml')->getUrl('*/sales_order/view', array('order_id'=>$order->getId())),
            );
        }

        $this->setResults($arr);

        return $this;
    }

[Flyingmana]

I would also say, if its becoming unusable with a large order history, thats a Bug worth to be fixed

[colinmollenhour]

The is_numeric optimization is a great one unless someone knows of a country where numbers are used in people's names.. 😆

[seansan]

Also thought of that In Dutch we have a saying for this : looking for nails in shallow water Translated something like: Listening for thunder when there is sunshine.

…

On Wed, 3 Oct 2018 at 17:22, Colin Mollenhour ***@***.***> wrote: The is_numeric optimization is a great one unless someone knows of a country where numbers are used in people's names.. 😆 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#541 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAn0ax_Em48rgu4mW1TdSYQ7T6T5xnyrks5uhNYsgaJpZM4XCs-j> .

[colinmollenhour]

To be clear I was advocating for that optimization, not against it.

[seansan]

We have a saying for that too: thumbs up!

…

On Wed, Oct 3, 2018 at 7:56 PM Colin Mollenhour ***@***.***> wrote: To be clear I was advocating *for* that optimization, not against it. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#541 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAn0axzYjsyet7SOor3J_NGx9Jmm4vZrks5uhPpggaJpZM4XCs-j> .