Merge pull request from GHSA-3p73-mm7v-4f6m

fballiano · Judx · fballiano · commit a4aeb13d23e4 · 2023-01-26T10:00:08.000Z
Co-authored-by: Judx &lt;juho.holsa@gmail.com&gt;
diff --git a/app/code/core/Mage/Core/Model/Input/Filter/MaliciousCode.php b/app/code/core/Mage/Core/Model/Input/Filter/MaliciousCode.php
@@ -58,17 +58,15 @@ class Mage_Core_Model_Input_Filter_MaliciousCode implements Zend_Filter_Interfac
      * Filter value
      *
      * @param string|array $value
-     * @return string|array         Filtered value
+     * @return string|array
      */
     public function filter($value)
     {
-        $result = false;
         do {
-            $subject = $result ? $result : $value;
-            $result = preg_replace($this->_expressions, '', $subject, -1, $count);
+            $value = preg_replace($this->_expressions, '', $value, -1, $count);
         } while ($count !== 0);
 
-        return $result;
+        return $value;
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -58,17 +58,15 @@ class Mage_Core_Model_Input_Filter_MaliciousCode implements Zend_Filter_Interfac`
`58`	`58`	`* Filter value`
`59`	`59`	`*`
`60`	`60`	`* @param string\|array $value`
`61`		`- * @return string\|array Filtered value`
	`61`	`+ * @return string\|array`
`62`	`62`	`*/`
`63`	`63`	`public function filter($value)`
`64`	`64`	`{`
`65`		`- $result = false;`
`66`	`65`	`do {`
`67`		`- $subject = $result ? $result : $value;`
`68`		`- $result = preg_replace($this->_expressions, '', $subject, -1, $count);`
	`66`	`+ $value = preg_replace($this->_expressions, '', $value, -1, $count);`
`69`	`67`	`} while ($count !== 0);`
`70`	`68`
`71`		`- return $result;`
	`69`	`+ return $value;`
`72`	`70`	`}`
`73`	`71`
`74`	`72`	`/**`