Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generators to use ideal template project #9890

Closed
yeekangc opened this issue Nov 20, 2019 · 15 comments
Closed

Update generators to use ideal template project #9890

yeekangc opened this issue Nov 20, 2019 · 15 comments
Assignees
Labels
Design Approved Epic Used to track Feature Epics that are following the UFO process Non-Release ReleaseCheckListAdded

Comments

@yeekangc
Copy link
Member

yeekangc commented Nov 20, 2019

Various starters or generators out there e.g. MP Start, RHR Launcher, IBM Cloud produce starter or template projects for developers to build with Open Liberty. This feature is to review and ensure that these starters or generators are using the recommended (ideal) template project for Open Liberty.

@gkwan-ibm @scottkurz

@yeekangc yeekangc added the Epic Used to track Feature Epics that are following the UFO process label Nov 20, 2019
@yeekangc yeekangc added the In Progress Items that are in active development. label Jan 27, 2020
@yeekangc
Copy link
Member Author

FYI, @meswan.

@atosak
Copy link

atosak commented Jan 28, 2020


List of Steps to complete or get approvals / sign-offs for Onboarding to the Liberty release (GM date)

Instructions:

  • Do the actions below and mark them complete in the checklist when they are done.
  • Make sure all feature readiness approvers put the appropriate tag on the epic to indicate their approval.

TARGET COMPLETION DATE Before Development Starts or 8 weeks before Onboarding

  • POC Design / WAD Review Scheduled (David Chang) or N/A.
  • POC Design / WAD Reviewed (Feature Owner) or N/A.
  • Complete any follow-ons from the POC Review.
  • Design / WAD Approval (Alasdair Nottingham) or N/A.
  • No Design / No WAD Approval (Arthur De Magalhaes - cloud / Alasdair Nottingham - server) or N/A.
  • SVT Requirements identified. (Epic owner / Feature owner with SVT focal point)
  • ID Requirements identified. (Epic owner / Feature owner with ID focal point)
  • Create a child task of the epic entitled "FAT Approval Test Summary". Add and fill in the template as described here: https://github.ibm.com/was-liberty/WS-CD-Open/wiki/Feature-Review-(Feature-Test-Summary-Process)

TARGET COMPLETION DATE 3 weeks before Onboarding

  • Identify all open source libraries that are changing or are new. Work with Legal Release Services (Cass Tucker or Release PM) to get open source cleared and approved. Or N/A. (Epic Owner). New or changed open source impacts license and Certificate of Originality.

TARGET COMPLETION DATE ** 3 weeks before Onboarding**

  • All new or changed PII messages are checked into the integration branch, before the last translation shipment out. (Epic Owner)

TARGET COMPLETION DATE 2 weeks before Onboarding

  • Implementation complete. (Epic owner / Feature owner)
  • All function tests complete. Ready for FAT Approval. (Epic owner / Feature owner)
  • Review all known issues for Stop Ship. (Epic owner / Feature owner / PM)

APPROVALS with TARGET COMPLETION DATE 2 to 1 week before Onboarding

Prereq: You must have the Design Approved or No Design Approved label on the GitHub Epic.

  • Accessibility - (G Scott Johnston). Accessibility testing is complete or N/A. Approver adds label focalApproved:accessibility to the Epic in Github.
  • FAT Liberty SOE - (Kevin Smith). SOE FATS are running successfully or N/A . Approver adds label focalApproved:fat to the Epic in Github.
  • Globalization (Sam Wong - Liberty / Simy Cheeran - tWAS). Translation is complete or N/A. TVT - complete or N/A. Approver adds label focalApproved:globalization to the Epic in Github.
  • ID - (Kareen Deen). Documentation work is complete or N/A . Approver adds label focalApproved:id to the Epic in Github.
  • Performance - (Jared Anderson). Performance testing is complete with no high severity defects or N/A . Approver adds label focalApproved:performance to the Epic in Github.
  • Serviceability - (Don Bourne). Serviceability has been addressed.
  • STE - (Swati Kasundra). STE chart deck is complete or N/A . Approver adds label focalApproved:ste to the Epic in Github.
  • SVT - (Greg Ecock - Cloud, Brian Hanczaryk- APS). SVT is complete or N/A . Approver adds label focalApproved:svt to the Epic in Github.
  • Demo - (Liberty only - Tom Evans or Chuck Bridgham). Demo is scheduled for an upcoming EOI. Approver adds label focalApproved:demo to the Epic in Github.

TARGET COMPLETION DATE 1 week before Onboarding

  • No Stop Ship issues for the feature. (Epic owner / Feature owner / Release PM)
  • Ship Readiness Review and Release Notes completed (Epic owner / Feature owner / Release PM)
  • Github Epic and Epic's issues are closed / complete. All PRs are committed to the master branch. (Epic owner / Feature owner / Backlog Subtribe PM)

NOT REQUIRED FOR A FEATURE

  • OL Guides - (Yee-Kang Chang). Assessment for OL Guides is complete or N/A.
  • WDT - (Leonard Theivendra). WDT work complete or N/A.

Related Deliverables TARGET COMPLETION DATE General Availability

  • Blog article writeup (Epic owner / Feature owner / Laura Cowen)

@yeekangc yeekangc changed the title Ideal template project and workflow Update generators to use ideal template project Sep 21, 2020
@yeekangc
Copy link
Member Author

Updated description with latest scope and pointers to related features.

@yeekangc yeekangc assigned meswan and unassigned scottkurz Sep 21, 2020
@covener
Copy link
Member

covener commented Sep 21, 2020

UFO Feedback/Actions:

  • As a starter/generator developer ... reword to reflect who that persona is?
  • upfront: clarify "the deliverable"
    • best practice published separately? This UFO (likely not enough)?
    • libertstarter + doc
  • p10: Not necessarily latest versions, needs to be able to be specified.
    • what about jakarta EE9 transition?
  • p10: latest liberty version? via docker tag.
  • p11: separate value from 'X' for will not fix, or draw line through row
    • don't update Codewind [further].
  • p11: microshed test + OL.io not listed
  • p11: eclipse starter is glassfish-only
  • p13: health check added by generator needs to match mpHealth level?
  • How will we keep known generators "compliant"?
  • Test/IT info on how used? The targets?
  • p18: don't encourage any default passwords [for keystores]
    • look into mpstarter behavior
  • p25: don't mention CLI

@yeekangc
Copy link
Member Author

yeekangc commented Nov 2, 2020

Adding Design Approval Request for @gkwan-ibm. @gkwan-ibm, can you please update with pointer to revised UFO?

@gkwan-ibm
Copy link
Member

The revised UFO is at https://ibm.ent.box.com/file/734356892041

@NottyCode
Copy link
Member

@gkwan-ibm @yeekangc you need to provide a publicly accessible UFO link

@gkwan-ibm
Copy link
Member

@gkwan-ibm
Copy link
Member

@NottyCode I posted the public link in the above comment. Thanks

@gkwan-ibm
Copy link
Member

All worked were done.

@gkwan-ibm
Copy link
Member

gkwan-ibm commented Jan 11, 2021

#9890 (comment)

The revised UFO is at https://ibm.ent.box.com/file/734356892041

@NottyCode would you review/approve the UFO?

@NottyCode
Copy link
Member

@gkwan-ibm Sorry for the delay here. I had an email discussion with some of our friends at Red Hat earlier in January. They observed the same thing we had that the RH Launcher support was not right, but in the course of that discussion we concluded that we shouldn't invest in fixing it, so I'd suggest changing the RH Launcher row to will not fix.

I've noticed that a few of the screenshots are out of date with regard to versions so I think it would be useful to have a separate table towards the end detailing the definitive dependencies and versions that will be added.

@gkwan-ibm
Copy link
Member

@NottyCode the UFO was updated for your comments

@yeekangc yeekangc removed the In Progress Items that are in active development. label Mar 16, 2021
@yeekangc
Copy link
Member Author

Closing as this has been delivered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Approved Epic Used to track Feature Epics that are following the UFO process Non-Release ReleaseCheckListAdded
Projects
Status: Non-Release Delivery Items
Development

No branches or pull requests

7 participants