Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MP Config 3.1 API, TCK & SmallRye jars #26663

Open
tevans78 opened this issue Oct 19, 2023 · 4 comments · Fixed by #26702 or #27348
Open

Update MP Config 3.1 API, TCK & SmallRye jars #26663

tevans78 opened this issue Oct 19, 2023 · 4 comments · Fixed by #26702 or #27348

Comments

@tevans78
Copy link
Member

Update to final version of API and TCK jars.
Update to latest applicable version of SmallRye Config.

@tevans78
Copy link
Member Author

#26702 only updated the API and TCK jars. Updating the SmallRye jars caused a TCK failure on Java 21 that needs investigation - #26767

@jakub-pomykala
Copy link
Contributor

The protected modifier has been removed from the SmallRyeConfigBuilder.getDefaultSources() which means our Override of the method is now not working. Opened an issue and PR in the SmallRye-config repo

@jakub-pomykala
Copy link
Contributor

jakub-pomykala commented Jan 25, 2024

Update reverted in #27455.

Due to:

  1. InstantOn builds: ConfigEnv updates are not reflected after restore. MP Config checkpoint feature failing tests after SmallRye-config 3.5.2 update #27523
  2. MP-config-1.3 Full FAT failing when looking up $$MPCONFIG_FATTEST_ENV_VARIABLE. (RTC 298683) MP Config 1.3 doesn't read "$$" properly causing test failures after SmallRye-config 3.5.2 update #27482

For 1: SmallRye are now creating more copies of ConfigEnvs in more locations (here) and we are trying to stop that in our implementation

@jakub-pomykala
Copy link
Contributor

We have a fix for both issues but by implementing the fix for #27482 we have detected another issue where Environment Variables are matched even though there is no exact match in the .env files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Icebox
2 participants