Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor automated UI test classes to make them easier to maintain #1082

Open
turkeylurkey opened this issue Nov 6, 2024 · 0 comments · May be fixed by #1083
Open

Refactor automated UI test classes to make them easier to maintain #1082

turkeylurkey opened this issue Nov 6, 2024 · 0 comments · May be fixed by #1083
Assignees
Labels
Milestone

Comments

@turkeylurkey
Copy link
Member

The classes SingleModMPProjectTestCommon and SingleModNLTRestProjectTestCommon define a large number of abstract methods which are actually just getters. This means all the classes that extend these base classes must implement the methods in exactly the same way. It would be simpler if the base classes simply implemented the getters one time and the derived classes used them.

This requires the base classes to define local variables and to implement setters as well as getters but this is quite simple to do and hence worthwhile to allow this refactoring to go forward.

@turkeylurkey turkeylurkey added this to the 24.0.12 milestone Nov 6, 2024
@turkeylurkey turkeylurkey self-assigned this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

1 participant