Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security hardening config isn't xml formatted #7627

Closed
NottyCode opened this issue Oct 10, 2024 · 5 comments · Fixed by #7653
Closed

security hardening config isn't xml formatted #7627

NottyCode opened this issue Oct 10, 2024 · 5 comments · Fixed by #7653
Assignees
Milestone

Comments

@NottyCode
Copy link
Member

The document here mentions 3 bits of server config, but doesn't show it as valid xml. It says:

* Add the `webAppSecurity ssoRequiresSSL="true"` statement to the `server.xml` file.
* Add the `webAppSecurity httpOnlyCookies="true"` statement to the `server.xml` file.
* Add the `httpOptions removeServerHeader="true"` statement to the `server.xml` file.
* Add the `webContainer disableXPoweredBy="true"` statement to the `server.xml` file.

and I think it would be better if it read:

* Add the `<webAppSecurity ssoRequiresSSL="true" />` statement to the `server.xml` file.
* Add the `<webAppSecurity httpOnlyCookies="true" />` statement to the `server.xml` file.
* Add the `<httpOptions removeServerHeader="true" />` statement to the `server.xml` file.
* Add the `<webContainer disableXPoweredBy="true" />` statement to the `server.xml` file.
@dmuelle
Copy link
Member

dmuelle commented Oct 10, 2024

Is there any reason we shouldn't display these as a block to reduce redundancy? ie

Add the following declarations to your server.xml file:

<webAppSecurity ssoRequiresSSL="true" httpOnlyCookies="true />
<httpOptions removeServerHeader="true" />
<webContainer disableXPoweredBy="true" />

@dmuelle dmuelle added this to the 24.0.0.11 milestone Oct 14, 2024
ramkumar-k-9286 added a commit that referenced this issue Oct 15, 2024
7627-security hardening config is not xml formatted-1

#7627
@ramkumar-k-9286
Copy link
Contributor

Hi @NottyCode

Suggested changes have been made.

Draft link: https://docs-draft-openlibertyio.mqj6zf7jocq.us-south.codeengine.appdomain.cloud/docs/latest/server-configuration-hardening.html

Please review the same and add the Developer Reviewed label if you are satisfied with the changes.

Regards,
Ramkumar

CC @dmuelle

@NottyCode
Copy link
Member Author

I would expect the text to stop be a bullet point, but it isn't.

ramkumar-k-9286 added a commit that referenced this issue Oct 16, 2024
7627-security hardening config is not xml formatted-2

#7627
@ramkumar-k-9286
Copy link
Contributor

Hi @NottyCode

Corrections were made as per your comment.

Draft link:

Server configuration security hardening

Please review the same and add the Developer Reviewed label if you are satisfied with the changes.

Regards,
Ramkumar

CC @dmuelle

@NottyCode
Copy link
Member Author

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants