Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to ICR page in GitHub repo #7428

Closed
leochr opened this issue Jul 19, 2024 · 4 comments · Fixed by #7461
Closed

Add link to ICR page in GitHub repo #7428

leochr opened this issue Jul 19, 2024 · 4 comments · Fixed by #7461
Assignees
Milestone

Comments

@leochr
Copy link
Member

leochr commented Jul 19, 2024

Document: Open Liberty container images
http://openliberty.io/docs/latest/container-images.html

Please describe the problem you are having with the documentation. Is information missing, inaccurate, or unclear? Tell us about the context where you encountered the problem so we can understand how to address it.

Add the following after the sentence "For example, if 23.0.0.12 is a recent quarterly release, you can pull an image that includes the 23.0.0.12 release with an OpenJ9 distribution of Java 8 by specifying the 23.0.0.12-full-java8-openj9-ubi tag.":

See the IBM Container Registry (ICR) page on the Open Liberty GitHub repository for the full list of supported Open Liberty container images.

@dmuelle dmuelle added this to the 24.0.0.8 milestone Jul 22, 2024
ramkumar-k-9286 added a commit that referenced this issue Jul 23, 2024
7428-Added link to ICR page in GitHub repo

#7428
@ramkumar-k-9286
Copy link
Contributor

Hi Leo @leochr

The suggested change has been made.

Draft Link:
https://docs-draft-openlibertyio.mqj6zf7jocq.us-south.codeengine.appdomain.cloud/docs/latest/container-images.html

Please review the same and add the Developer Reviewed label if you are satisfied with the change.

Regards,
Ramkumar.

CC @dmuelle

@leochr
Copy link
Member Author

leochr commented Jul 23, 2024

@ramkumar-k-9286 Thanks for the update. On second thought, I believe it'll be better to add it after this sentence instead:
"For more information about these tag values, see the Container image tags naming conventions section."

ramkumar-k-9286 added a commit that referenced this issue Jul 24, 2024
7428-Added link to ICR page in GitHub repo-2

#7428
@ramkumar-k-9286
Copy link
Contributor

Hi Leo @leochr

I have moved the information as per your suggestion.

Draft Link:
https://docs-draft-openlibertyio.mqj6zf7jocq.us-south.codeengine.appdomain.cloud/docs/latest/container-images.html

Please review the same and add the Developer Reviewed label if you are satisfied with the change.

Regards,
Ramkumar.

CC @dmuelle

@leochr
Copy link
Member Author

leochr commented Jul 24, 2024

@ramkumar-k-9286 Looks good. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants