Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve auto OAuth2 for permission request changes #1077

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

madprime
Copy link
Member

@madprime madprime commented Nov 5, 2019

Description

Avoid "auto authorization" when requested permissions change for an OAuth2 project.

This is done by checking permissions and redirecting to reload the same endpoint with an updated approval_prompt parameter, thus prompting re-authorization by the user.

Related Issue

#1076

Testing

  • passed automated testing locally
  • ran locally to test manually:
    • reproduced incorrect auto auth when permissions update
    • confirmed corrected behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant