Support a preparing status for meetups. #80
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tristandunn could i convince you to rebase this? still thinking of doing this. |
| @@ -29,11 +29,12 @@ task :city do | |||
| # 'Banana City, NY' => 'banana_city' | |||
| directory = name.split(',')[0].downcase.gsub(/\s+/, '_') | |||
| FileUtils.mkdir_p(directory) | |||
| preparing = "\nstatus: preparing" if ENV["PREPARING"] | |||
There was a problem hiding this comment.
is this necessary? why wouldn't all new open hacks be preparing by default?
There was a problem hiding this comment.
Good call, updated my branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a "Coming Soon" section to the city navigation where preparing cities are listed. Cities that are preparing also have a little notice on their pages.
(It might be better to just move the notice to the Markdown instead of having two statuses. I didn't see a way to access the YAML from the homepage.)
Also, if this is merged, whoever does so gets one free punch for me including whitespace and refactoring in a feature pull request.
This fixes #71.