Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a constants src file #655

Closed
manthey opened this issue Dec 12, 2016 · 0 comments
Closed

Add a constants src file #655

manthey opened this issue Dec 12, 2016 · 0 comments

Comments

@manthey
Copy link
Contributor

manthey commented Dec 12, 2016

Currently, we have constant values in both src/events.js and src/actions.js (and possibly elsewhere). It would be handy if there was a src/constants.js file that exported all of these in a single namespace (geo.constants.*).

This would also be an appropriate place to add additional constants to replace some internal special values, such as the use of null as the gcs to mean the map's display gcs. See the conversation in PR #654 for more background on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants