Increase coverage to 75% or more

[aashish24]

No description provided.

[aashish24]

Ref: #329

[aashish24]

• ChoroplethFeature - Aashish
• Graph - Jon
• FileReader - Jon
• GeomFeature - Aashish (will remove it)
• JSONReader - Jon?
• LineFeature - David
• Contour - David
• WiggleMaps - Jon
• GraphFeature - Jon
• Utils - Jon
• LegendWidget - ?

[manthey]

I notice that we have a clock module which doesn't have tests. It is instantiated with a map, but then we don't seem to do anything with it. Obviously, some consumer of geojs might use it, but we could get rid of it before we release v1.0.

[aashish24]

I notice that we have a clock module which doesn't have tests. It is instantiated with a map, but then we don't seem to do anything with it. Obviously, some consumer of geojs might use it, but we could get rid of it before we release v1.0.

I believe clock is used for animations which are time based. We had one example in the past.

[aashish24]

My preference would be to keep it, add an example and test unless the features provided by it are replaced by some other module.

[manthey]

You are right; the dynamicData example uses it.

[jbeezley]

There are integration tests for it in d3Animation. The class itself was originally intended to be used for time synchronization in animations.

I don't think we've ever found a use for it in production, which IMO is a good metric for the usefulness of an API. The 1.0 tag is a good opportunity to rethink API decisions that didn't pan out.

[aashish24]

I don't think we've ever found a use for it in production, which IMO is a good metric for the usefulness of an API. The 1.0 tag is a good opportunity to rethink API decisions that didn't pan out.

+1

[aashish24]

@jbeezley @manthey should we close this since now we are > 90%?

[manthey]

We still have one source file that is essentially uncovered: the ui/legendWidget.js is only got 8% coverage. I'd like to see it tested.

[aashish24]

We still have one source file that is essentially uncovered: the ui/legendWidget.js is only got 8% coverage. I'd like to see it tested.

makes sense. Would it be @jbeezley that was planning to increase the coverage of legendWidget?

[aashish24]

@jbeezley @manthey I am thinking of closing this, we can create specific issues related to low coverage on certain files but feel free to re-open this if you think we should.