Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mousewheel event should report freshly obtained mouse coordinates #1025

Closed
waxlamp opened this issue Sep 12, 2019 · 1 comment · Fixed by #1027
Closed

Mousewheel event should report freshly obtained mouse coordinates #1025

waxlamp opened this issue Sep 12, 2019 · 1 comment · Fixed by #1027

Comments

@waxlamp
Copy link
Contributor

waxlamp commented Sep 12, 2019

No description provided.

waxlamp added a commit to TRI-AMDD/materialnet that referenced this issue Sep 12, 2019
@waxlamp
Hang onto and expand the same "next expansion focus" point
a0a53dd 
This is due to a limitation in how GeoJS works: the mouse coordinates
are not properly re-read on mousewheel events (but they are on
mousemove), so the workaround is to allow mousemove to clear the focus
point, but maintain it otherwise, always pushing the expansion factor
into it during a sequence of non-moving mousewheel events.

@manthey advised me on this problem, and I've opened [a GeoJS
issue](OpenGeoscience/geojs#1025) about it.
@manthey manthey mentioned this issue Sep 14, 2019
Merged
@manthey
Copy link
Contributor

manthey commented Sep 16, 2019

@waxlamp THere is a fix in #1027, if you'd like to try it out or review it. There are build artifacts here if those are useful for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set mouse position as part of wheel events. OpenGeoscience/geojs
2 participants
@waxlamp @manthey