Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review the Settings class and its defaults #373

Open
IAlibay opened this issue Oct 25, 2024 · 0 comments
Open

Review the Settings class and its defaults #373

IAlibay opened this issue Oct 25, 2024 · 0 comments

Comments

@IAlibay
Copy link
Member

IAlibay commented Oct 25, 2024

The Settings class (https://github.com/OpenFreeEnergy/gufe/blob/main/gufe/settings/models.py#L212) is often used as "the class you should subclass when creating a Settings object for a Protocol".

However it has some preset fields that aren't appropriate for some Settings classes (for example the AHFE Protocol). This means that such Protocol Settings need to subclass SettingsBaseModel rather than Settings.

If we want a unified parent class for our Settings objects, we may need to review exactly what the Settings class contains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant