Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worker: take a single lightning baseURL as an argument #809

Open
josephjclark opened this issue Oct 29, 2024 · 0 comments
Open

worker: take a single lightning baseURL as an argument #809

josephjclark opened this issue Oct 29, 2024 · 0 comments

Comments

@josephjclark
Copy link
Collaborator

I'm about to implement a new argument to the worker to support collections - --collections-url

But it's a bit annoying because we already take a lightning-service-url. We can't use it because it points to a websocket.

I wonder if we can just take a --lightning-url as an argument, which points to http(s)://, and from that we derive the websocket (ws(s)://<lightning>/worker) and collections (http(s)://<lightning>/collections endpoints.

That's a breaking change because we're changing startup arguments which will break deployments. I'd suggest we introduce the new argument but leave the other two in place.

When we do worker 2.0, we'll drop the old arguments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New Issues
Development

No branches or pull requests

1 participant