Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review: Technology data generation wind turbine #92

Open
10 of 15 tasks
steull opened this issue Feb 11, 2022 · 7 comments
Open
10 of 15 tasks

Review: Technology data generation wind turbine #92

steull opened this issue Feb 11, 2022 · 7 comments
Assignees
Labels
review Data and Metadata review v1.5.1 metadata created with version 1.5.1

Comments

@steull
Copy link
Contributor

steull commented Feb 11, 2022

Issue description

I'm submitting an open dataset with a corresponding OEMetadata string for review.

Workflow checklist

  1. GitHub
  • I have submitted this issue to have metadata and data review documented (Issue Review: Technology data generation wind turbine #92  #93 )
  • Create a new review-branch and push OEMetadata to new branch (review/project_nameofdata#NR). If this step is too difficult, attach a file with the metadata as a comment in this issue and let the reviewer know.
  1. OEP
  • Upload data to the OEP in schema model_draft (see upload tutorial)
  • Link URL of data in this issue (model_draft.project_nameofdata)
  1. Start a Review
  • Start a pull request (PR) from review-branch to master
  • Assign a reviewer and get in contact
  1. Reviewer section
  • A reviewer starts working on the issue
  • Review data license
  • A reviewer finished working on this issue (and awarded a badge)
  • Update metadata on table
  • Data moved to its final schema
  • Add OEP tags to table
  • Merge PR and delete review-branch
  • Document final links of metadata and data in issue description
  • Close issue

Metadata and data for review

Here are the links to my data and metadata. Naming follows the pattern model_draft.project_nameofdata:
Metadata:

Data: https://openenergy-platform.org/dataedit/view/model_draft/rli_dea_td_generation_wind_turbine

Reviewed and published metadata and data

Final naming and location of the data and metadata after the review are as follows:
schema.tablename

@steull steull added the review Data and Metadata review label Feb 11, 2022
steull added a commit that referenced this issue Feb 11, 2022
@chrwm chrwm assigned chrwm and unassigned christian-rli Feb 14, 2022
@chrwm
Copy link
Member

chrwm commented Feb 14, 2022

Hi, @steull thanks for starting the review process. Unfortunately, the links to data and metadata seem corrupted. Please fix them.

@Ludee
Copy link
Member

Ludee commented Feb 14, 2022

Fixed the metadata link but the data is not uploaded yet.

@steull
Copy link
Contributor Author

steull commented Feb 14, 2022

Data are uploaded on the OEP. Link is attached.

@jh-RLI
Copy link
Contributor

jh-RLI commented Feb 14, 2022

@steull please also grant permissions to table. You can add the RLI user group. Use the red permissions button next to the table view on the OEP :)

@steull
Copy link
Contributor Author

steull commented Feb 14, 2022

Thank you for this hint. I added RLI user group as admin.

Ludee added a commit that referenced this issue Feb 14, 2022
Ludee added a commit that referenced this issue Feb 14, 2022
Ludee added a commit that referenced this issue Feb 14, 2022
Ludee added a commit that referenced this issue Feb 14, 2022
Ludee added a commit that referenced this issue Feb 14, 2022
@chrwm
Copy link
Member

chrwm commented Feb 14, 2022

Thanks for the fix. I'm not sure whether "wind_turbine" needs to be in every column name, but besides that, the data description looks fine. Did we also want to demonstrate the ontology within the metadata? In this case, the "is_about" field needs to be filled out.

Ludee added a commit that referenced this issue Feb 14, 2022
Ludee added a commit that referenced this issue Feb 14, 2022
Ludee added a commit that referenced this issue Feb 14, 2022
Ludee added a commit that referenced this issue Feb 15, 2022
@steull steull added the v1.5.1 metadata created with version 1.5.1 label Mar 1, 2022
@steull steull assigned steull and unassigned Ludee, jh-RLI and chrwm Mar 1, 2022
steull added a commit that referenced this issue Apr 4, 2022
@Ludee Ludee linked a pull request Apr 4, 2022 that will close this issue
@steull steull closed this as completed in #94 Apr 4, 2022
@steull
Copy link
Contributor Author

steull commented Apr 7, 2022

Linked the wrong pull request which closed the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Data and Metadata review v1.5.1 metadata created with version 1.5.1
Projects
None yet
Development

No branches or pull requests

5 participants