Skip to content

review/wind_turbine_library #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
christian-rli opened this issue Jun 13, 2019 · 12 comments
Open

review/wind_turbine_library #26

christian-rli opened this issue Jun 13, 2019 · 12 comments
Assignees
Labels
review Data and Metadata review

Comments

@christian-rli
Copy link
Contributor

christian-rli commented Jun 13, 2019

The table has been renamed to: wind_turbine_library
https://openenergy-platform.org/dataedit/view/supply/wind_turbine_library

The turbine library is a collection of wind turbine data. It is available here: https://openenergy-platform.org/dataedit/view/supply/wind_turbine_library ready to be reviewed and extended. The corresponding metadata string can be observed here.

For review guidelines you can have a look here.

@christian-rli christian-rli added the review Data and Metadata review label Jun 13, 2019
@christian-rli
Copy link
Contributor Author

During my upload of the metadata string i stumbled across the other files within that folder. They are all sql-files, which made me think. The idea in all of these is to first define a table at the final location with all column definitions, granting user privileges and adding the metadata, basically as a comment in the form of a json-string. It even includes scenario log entries. This is a great way to reconstruct the creation of the data in the database. However I would argue that this is something to be considered internal to the database.
There is a very limited number of people with sql-access to the database. Access to it should all be going via oedialect, which then takes care of logging internally. Column descriptions should be sufficiently supplied within the metadata.
For these reasons I only uploaded the metadata as a pure json-file. For completeness sake I should maybe also include the python upload script that uses oedialect? Feel free to convince me that another approach makes more sense.

@Ludee
Copy link
Member

Ludee commented Jun 13, 2019

You are totally right!
The "SQL-way" is limited to OEP developers. The API and oedicalect are not able to work with the metadata yet. This is very import. Is this something OMI will fix!?

@christian-rli
Copy link
Contributor Author

OMI will support the translation of metadata json from older to newer versions and to rdf. Since there are a lot of old strings in the database, this is a prerequisite for a general oedialect support of metadata strings. So with OMI support is on its way, as of yet I'm just not how long it'll take.

@jh-RLI
Copy link
Contributor

jh-RLI commented Aug 6, 2019

@christian-rli I updated the metadatastring for this table to oep-v1.4 and pushed the file here.

I also added the missing metadatastring as comment on table. I tried to use the updated version but it seems like the oep data view having trouble to display the string correctly. Because of that I added the old oep-v1.3 string.

@Ludee should the OEP data view work with the new metadata version?

@christian-rli
Copy link
Contributor Author

Thank you @jh-RLI ! The new standard "OEP-1.4.0" is not implemented in OEP as of yet. @MGlauer is working on it however. So it should come soon. For now it's fine as version "OEP-1.3". ☮

@euronion
Copy link

euronion commented Aug 9, 2019

Hi there! (thanks @coroa for pointing me here)
We recently connected the turbine_library to our project Atlite
and while writing the connector I came across some things which I would like to comment on
(partially metadata, partially homogenisation in the data formats).

sorry if this is OT - maybe I missed the appropriate place for these questions:
I am not sure how to contribute: Is there a how-to? (The review guidelines didn't answer this question for me).
Also: Is the version in this issue already reflected in the OEDB. Because it changed since I checked last week and I failed to find any indicator, which version the database viewer is offering and when it was last updated?!

Hope you can get me up to speed so I can provide some additions. :)

@Ludee
Copy link
Member

Ludee commented Aug 12, 2019

Hi @euronion,

this is the correct issue for the moment. We will set a link to the windpowerlib as well. We are happy to collaborate and are always open for comments and contributions!

We (@christian-rli) were working on the "official release" of the wind turbine library last week. The current version was for testing only. We discussed a renaming and fixed some power curves.
The OEP metadata version has been updated as well.
The data versioning of the OEP is not implemented in total yet. Working on it ;)

@Ludee
Copy link
Member

Ludee commented Aug 13, 2019

After an internal group discussion we decided to rename the table and specify that we are collecting wind turbine specifications. The metadata is using the new version 1.4.0 and is not yet displayed on the OEP. The contributions can be made in the new ticket #28

@christian-rli
Copy link
Contributor Author

christian-rli commented Aug 13, 2019

@MGlauer uploading metadata in version 1.4.0 to the OEDB won't result in a correct display thereof. omi's v1.4 support was merged in this PR. What will it take to have it working on the OEP? Can I help somehow?

@Ludee Ludee changed the title review/turbine_library review/wind_turbine_library Aug 21, 2019
@jh-RLI
Copy link
Contributor

jh-RLI commented May 17, 2021

@steull steull added v1.4 metadata created with version 1.4 and removed v1.4 metadata created with version 1.4 labels Jun 23, 2022
@SMEISEN
Copy link

SMEISEN commented Nov 22, 2023

The table has been renamed to: wind_turbine_library https://openenergy-platform.org/dataedit/view/supply/wind_turbine_library

The turbine library is a collection of wind turbine data. It is available here: https://openenergy-platform.org/dataedit/view/supply/wind_turbine_library ready to be reviewed and extended. The corresponding metadata string can be observed here.

For review guidelines you can have a look here.

Hello, I would like to extend the database. Unfortunately, I could not find a description how to propose new entries.

@jh-RLI
Copy link
Contributor

jh-RLI commented Nov 23, 2023

Great to hear!

It would be great if you could provide a file.csv here to show what you want to update. If the file contains a lot of entries, it's also fine to provide a subset of it.

I need to double check what our current process looks like. As I recall, we would need to move the table to the "model_draft" topic in the OEP, then upload the data, then move it back. This requires access permissions. I can assist you with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Data and Metadata review
Projects
None yet
Development

No branches or pull requests

6 participants