Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React hooks for admin map viewing pages #891

Closed
huss opened this issue Apr 19, 2023 · 1 comment
Closed

React hooks for admin map viewing pages #891

huss opened this issue Apr 19, 2023 · 1 comment
Milestone

Comments

@huss
Copy link
Member

huss commented Apr 19, 2023

Is your feature request related to a problem? Please describe.

Please see issue #726 for information.

Describe the solution you'd like

The admin map viewing page located in files src/client/app/components/maps/MapsDetailComponent.tsx, src/client/app/containers/maps/MapsDetailContainer.tsx, src/client/app/components/maps/MapViewComponent.tsx & src/client/app/containers/maps/MapViewContainer.tsx need to be updated for React hooks.

The look of this page will change substantially to align with the new modal card look in OED. The new look is already on the pages for conversions, groups, meters & units and found in the related name directories under src/client/app/components/ where meter is likely to be the closest to the user modal code. The top of the page will have a create button that takes the admin to the page to create a map that uses the current pages. Note this is actually a sequence of pages. A card for each map will have the map name, map display & note (30 characters max as on current modal pages) listed along with a button to edit the meter.

When the edit button is clicked, a modal pops up that shows all the values on the current page except the id that will not be shown. The admin can modify any of them except the last modify date that is set by the software. The actions takes on a change will be similar to the current page but the look should be consistent with the new modal pages. For example, the button to delete the map similar to the conversion page.

Note the current page allows for editing multiple maps but that will not be allowed on the new page. Only one map at a time to be consistent with other modal pages. The change to the modal setup may change a number of the functions and state interactions.

Additional context

Given what is done when a map is created/calibrated, it is unclear if that should be a modal as we want it to be the full size of the page. At some point, it should be checked to see if changing it would make sense.

@huss huss added the reserved Expected to be assigned to developer by project so others should not work on without prior approval. label Apr 19, 2023
@huss huss added this to the 1.1 release milestone Apr 19, 2023
@huss huss mentioned this issue May 9, 2023
10 tasks
@huss huss removed the reserved Expected to be assigned to developer by project so others should not work on without prior approval. label Sep 26, 2023
@huss
Copy link
Member Author

huss commented Apr 4, 2024

This is replaced by issues #1145 & #1197 so closing.

@huss huss closed this as completed Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant