Maps Update: Cards and Modals for Maps Components #1314
Conversation
There was a problem hiding this comment.
Thanks to @juanjoseguva for doing this work. I've made some comments that will require non-trivial changes. Please let me know if anything is not clear or I can help.
| </FormGroup> | ||
| </Form> | ||
| <div> | ||
| <Label><FormattedMessage id="map.filename" /></Label> |
There was a problem hiding this comment.
Please see conversion edit for how uneditable items should look.
There was a problem hiding this comment.
From what I see this still does not look the way the mentioned page works. Am I missing something?
juanjoseguva
changed the title
…atus as they are no longer relevant in the new modals
|
All comments have been addressed and this PR is ready for review @huss. |
|
This PR includes some migrations of map components/containers to RTK as requested in issue #1145, however more components such as the calibration components need updated still. |
- maps no longer a state property, - old State type deleted, only use RootState now - admin pages untested, graph seems okay. - needs testing.
|
@huss
Have yet to test, so its likely revisions are needed. |
- Legacy Actions/Creators deleted, - unused actions deleted - unused types deleted - maps files purged. - comments.
ChrisMart21
added
the
p-high-priority
- queryTimeIntervalString - rangeSliderIntervalString - barDuration - mapsBarDuration - compareTimeIntervalString - Re-Enable DevModeChecks
|
Wanted to note that I started to merge this with development to remove conflicts. There are some files that need careful merging due to the barDuration vs mapDuration (not longer separated by graphic type) and the map circle size. I plan to do this but am putting it off for now to move reviewing code forward. |
| @@ -34,6 +32,8 @@ import { AreaUnitType, getAreaUnitConversion } from '../utils/getAreaUnitConvers | |||
| import getGraphColor from '../utils/getGraphColor'; | |||
| import translate from '../utils/translate'; | |||
There was a problem hiding this comment.
I'm migrating translate to useTranslate as part of #1354 . Can you please migrate to useTranslate() from componentHooks.ts
Description
Updating Maps page to display as cards with modals, matching the other pages.
UPDATE:
Type of change
Checklist
Limitations
Saving functionality should be moved into the modals, and the save changes button under the cards should be deleted.
UPDATE: The migration maintains much of the prior functionality but, for simplicity, some of the maps logging was temporarily omitted. Logging as a whole should be carefully planned and implemented in a future PR for the omitted logs from maps, but fort he application as a whole.