Change reset delay and allow App0 after TFUc

Author: RobertZ2011

src/asynchronous/embassy/task.rs

@@ -1,4 +1,4 @@
-use defmt::error;
+use defmt::{error, warn};
 use embassy_sync::blocking_mutex::raw::RawMutex;
 use embedded_hal::digital::InputPin;
 use embedded_hal_async::{digital::Wait, i2c::I2c};
@@ -17,7 +17,7 @@ pub async fn interrupt_task<const N: usize, M: RawMutex, B: I2c, INT: Wait + Inp
 
         for interrupt in &mut interrupts {
             if let Err(_) = interrupt.process_interrupt(int).await {
-                error!("Error processing interrupt");
+                warn!("Error processing interrupt");
             }
         }
     }

src/asynchronous/internal/command.rs

@@ -148,7 +148,7 @@ impl<B: I2c> Tps6699x<B> {
 
         // Confirm we're in the correct mode
         let mode = self.get_mode().await?;
-        if mode != Mode::App1 {
+        if mode != Mode::App0 && mode != Mode::App1 {
             error!("Failed to enter normal mode, mode: {:?}", mode);
             return Err(PdError::InvalidMode.into());
         }

src/asynchronous/internal/mod.rs

@@ -1,6 +1,5 @@
 //! This module implements a low-level TPS6699x driver. The super module provides a high-level API
 //! that uses standard PD types and provides functions that implement features that may occur over several interrupts
-use defmt::debug;
 use embedded_hal_async::delay::DelayNs;
 use embedded_hal_async::i2c::I2c;
 use embedded_usb_pd::{Error, PdError, PortId};
@@ -36,12 +35,6 @@ impl<B: I2c> device_driver::AsyncRegisterInterface for Port<'_, B> {
         // Sized to accommodate up to 255 bytes of data
         let mut buf = [0u8; 257];
 
-        debug!(
-            "PD write, address: {:#x}, register: {:#x}, length: {}",
-            self.addr,
-            address,
-            data.len()
-        );
         // Buffer length is sent as a byte
         if data.len() > 255 {
             return Err(PdError::InvalidParams.into());
@@ -68,13 +61,6 @@ impl<B: I2c> device_driver::AsyncRegisterInterface for Port<'_, B> {
         let full_len = data.len() + 1;
         let reg = [address];
 
-        debug!(
-            "PD read, address: {:#x}, register: {:#x}, length: {}",
-            self.addr,
-            address,
-            data.len()
-        );
-
         if data.is_empty() {
             return Err(PdError::InvalidParams.into());
         }

src/command.rs

@@ -8,7 +8,7 @@ pub const REG_DATA1_LEN: usize = 64;
 
 /// Delay after reset before we can assume the controller is ready
 // Derived from experimentation
-pub const RESET_DELAY_MS: u32 = 1600;
+pub const RESET_DELAY_MS: u32 = 2000;
 pub const RESET_TIMEOUT_MS: u32 = RESET_DELAY_MS + 100;
 pub const TFUS_DELAY_MS: u32 = 500;
 pub const TFUS_TIMEOUT_MS: u32 = TFUS_DELAY_MS + 100;