Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASSERT_VERSION vars not set for javascript assets #1812

Open
baszoetekouw opened this issue Feb 19, 2025 · 1 comment
Open

ASSERT_VERSION vars not set for javascript assets #1812

baszoetekouw opened this issue Feb 19, 2025 · 1 comment

Comments

@baszoetekouw
Copy link
Member

EB loads in assets with urls like this:

Probably the substitution for #ASSERT_VERSION# is missing int he build process somewhere?

@baszoetekouw baszoetekouw added bug javascript Pull requests that update Javascript code labels Feb 19, 2025
@thijskh
Copy link
Member

thijskh commented Feb 19, 2025

This is done in bin/makeRelease.sh. The new tarfiles (with the extremely long names) are no longer built by this script. So the github action that builds these releases needs to incorporate this step:

sed -i s,#ASSET_VERSION#,${TAG},g ${PROJECT_DIR}/app/config/config.yml &&

@thijskh thijskh added github-actions and removed javascript Pull requests that update Javascript code labels Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants