Improve log: add issuer to debug message #1782
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It sound like there are two separate issue here:
|
baszoetekouw
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
In principle this looks fine, but I'd like to see if we can find a more generic solution (see #1806)
I would if I were able to reproduce, but I can't seem to trigger this exception anymore.. I'm putting |
|
Strike that, the code is run after completing authentication at the IdP and not when the request is received.. Will open a new issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Btw, I see this log message 4 times per authentication