Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backend/frontend] Implementation of sensitive configuration protection (#8284) #8509

Merged
merged 26 commits into from
Oct 4, 2024
Merged

[backend/frontend] Implementation of sensitive configuration protection (#8284) #8509

merged 26 commits into from
Oct 4, 2024

Conversation

aHenryJard
Copy link
Member

@aHenryJard aHenryJard commented Sep 25, 2024 •
edited
Loading

Proposed changes

  • Add a configuration in Role to know if user is allow or not to change sensitive configuration on the platform

  • Add this configuration in the capability list in the UI

  • Protect initial groups/roles Administrator(s) and Connector(s) from modification when user are not allow to modifiy sensitve configuration

  • Under feature flag PROTECT_SENSITIVE_CHANGES

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Sep 25, 2024
@aHenryJard aHenryJard changed the title Implementation of sensitive configuration protection (#8284) [backend/frontend] Implementation of sensitive configuration protection (#8284) Sep 27, 2024
@marieflorescontact marieflorescontact marked this pull request as ready for review September 30, 2024 16:29
@codecov Codecov
Copy link

codecov bot commented Sep 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 34.14634% with 54 lines in your changes missing coverage. Please review.

Project coverage is 66.19%. Comparing base (e073151) to head (7b2713b).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...pencti-graphql/src/database/data-initialization.js 0.00% 50 Missing ⚠️
...encti-platform/opencti-graphql/src/domain/grant.js 75.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8509      +/-   ##
==========================================
- Coverage   66.22%   66.19%   -0.03%     
==========================================
  Files         597      597              
  Lines       60436    60500      +64     
  Branches     6202     6207       +5     
==========================================
+ Hits        40025    40050      +25     
- Misses      20411    20450      +39

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marieflorescontact marieflorescontact force-pushed the issue/8284-chunk1 branch 2 times, most recently from 76dfb26 to 7fb7cfd Compare October 2, 2024 06:53
marieflorescontact and others added 17 commits October 4, 2024 09:55
@Kedae Kedae merged commit 89aea0a into master Oct 4, 2024
1 of 4 checks passed
@Kedae Kedae deleted the issue/8284-chunk1 branch October 4, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marieflorescontact marieflorescontact marieflorescontact left review comments

@SouadHadjiat SouadHadjiat Awaiting requested review from SouadHadjiat

Assignees

@aHenryJard aHenryJard

@marieflorescontact marieflorescontact

Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aHenryJard @SouadHadjiat @marieflorescontact @Kedae