Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marking values order: change TLP:AMBER+STRICT to be hierarchically greater than TLP:AMBER #9450

Open
romain-filigran opened this issue Dec 23, 2024 · 3 comments · May be fixed by #9515
Open

Marking values order: change TLP:AMBER+STRICT to be hierarchically greater than TLP:AMBER #9450

romain-filigran opened this issue Dec 23, 2024 · 3 comments · May be fixed by #9515
Assignees
@aHenryJard @CelineSebe
Labels
bug use for describing something not working as expected

Comments

@romain-filigran
Copy link
Member

Description

It seems more logic to differentiate the order between TLP:AMBER and TLP:AMBER+STRICT has the scope is more restricted in TLP:AMBER+STRICT definition.
TLP:AMBER+STRICT should be hierarchically superior to TLP:AMBER

Environment

  1. OpenCTI version: 6.4.5
@romain-filigran romain-filigran added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels Dec 23, 2024
@nino-filigran nino-filigran removed the needs triage use to identify issue needing triage from Filigran Product team label Jan 2, 2025
@aHenryJard
Copy link
Member

you means on first platform start ? Like this =>
TLP:AMBER => order = 3
TLP:AMBER+STRICT => order = 4
TLP:RED => order = 5

Because after that users can change the marking order in security > Marking definition

@aHenryJard
Copy link
Member

implementation note: initialization of marking is here

opencti/opencti-platform/opencti-graphql/src/database/data-initialization.js

Lines 137 to 195 in 8a66e8b

const createMarkingDefinitions = async (context) => {
// Create marking defs for TLP
await addAllowedMarkingDefinition(context, SYSTEM_USER, {
definition_type: 'TLP',
definition: 'TLP:CLEAR',
x_opencti_color: '#ffffff',
x_opencti_order: 1,
});
await addAllowedMarkingDefinition(context, SYSTEM_USER, {
definition_type: 'TLP',
definition: 'TLP:GREEN',
x_opencti_color: '#2e7d32',
x_opencti_order: 2,
});
await addAllowedMarkingDefinition(context, SYSTEM_USER, {
definition_type: 'TLP',
definition: 'TLP:AMBER',
x_opencti_color: '#d84315',
x_opencti_order: 3,
});
await addAllowedMarkingDefinition(context, SYSTEM_USER, {
definition_type: 'TLP',
definition: 'TLP:AMBER+STRICT',
x_opencti_color: '#d84315',
x_opencti_order: 3,
});
await addAllowedMarkingDefinition(context, SYSTEM_USER, {
definition_type: 'TLP',
definition: 'TLP:RED',
x_opencti_color: '#c62828',
x_opencti_order: 4,
});
// Creation markings for PAP
await addAllowedMarkingDefinition(context, SYSTEM_USER, {
definition_type: 'PAP',
definition: 'PAP:CLEAR',
x_opencti_color: '#ffffff',
x_opencti_order: 1,
});
await addAllowedMarkingDefinition(context, SYSTEM_USER, {
definition_type: 'PAP',
definition: 'PAP:GREEN',
x_opencti_color: '#2e7d32',
x_opencti_order: 2,
});
await addAllowedMarkingDefinition(context, SYSTEM_USER, {
definition_type: 'PAP',
definition: 'PAP:AMBER',
x_opencti_color: '#d84315',
x_opencti_order: 3,
});
await addAllowedMarkingDefinition(context, SYSTEM_USER, {
definition_type: 'PAP',
definition: 'PAP:RED',
x_opencti_color: '#c62828',
x_opencti_order: 4,
});
};

@CelineSebe CelineSebe linked a pull request Jan 7, 2025 that will close this issue
Draft
5 tasks
@CelineSebe CelineSebe linked a pull request Jan 7, 2025 that will close this issue
[backend] Change marking values order: TLP:AMBER+STRICT to be hierarchically greater than TLP:AMBER (#9450) #9515
Draft
5 tasks
@CelineSebe
Copy link
Member

@romain-filigran
Is modifying the order in the UI settings > customization sufficient? Or should I open a PR to change the order of markings during the platform initialization?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aHenryJard aHenryJard

@CelineSebe CelineSebe

Labels
bug use for describing something not working as expected
Projects
None yet
Milestone
No milestone
4 participants
@aHenryJard @CelineSebe @nino-filigran @romain-filigran