Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop blocking the CTRL/CMD button #1153

Open
heliodor opened this issue Jun 27, 2024 · 3 comments
Open

Stop blocking the CTRL/CMD button #1153

heliodor opened this issue Jun 27, 2024 · 3 comments
Labels
enhancement Improving existing functionality need decision

Comments

@heliodor
Copy link

Holding down CTRL on Windows or CMD on OSX while clicking is used for opening new tabs.

The site seems to be absorbing keyboard events and it's interfering with this standard browser behavior.

General concept that should be respected / implemented:
Keyboard events should be allowed to flow up to the browser level instead of being blocked.

@heliodor
Copy link
Author

This is happening inside the search widget that's located at the top of the page. Type something, get results, try to CTRL/CMD click any of them.

Not sure if it's a problem elsewhere on the site because I see that it does work in other parts.

@adamgilg
Copy link
Contributor

adamgilg commented Sep 17, 2024

@heliodor I'm taking a look into this as part of generally getting to know the React app. We don't fully control the keyboard events etc here as it's built with algolia/autocomplete-js. They've implemented the individual list elements to not show as links, which is why you aren't getting the option to open the links in a new tab. However, it should be possible to use their keyboard navigation to enable cmd+return at least, though I'm not sure if it will work for cmd+click.

I have to explore this further as it'll take some adjustment of the autocomplete component to make it work. It may also not have been implemented until a later version of algolia/autocomplete-js - the app is on 1.7, and the current version is 1.17. So we may also need to look into updating to a newer version of the library, which of course adds further complication.

@musoke
Copy link
Contributor

musoke commented Oct 21, 2024

I would find this very helpful.

@musoke musoke added enhancement Improving existing functionality need decision labels Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing functionality need decision
Projects
None yet
Development

No branches or pull requests

3 participants