From b094e4e4d3fc270f37073838624fb964f72745fb Mon Sep 17 00:00:00 2001
From: Marine LM <marine.lemezo@filigran.io>
Date: Thu, 26 Sep 2024 17:41:18 +0200
Subject: [PATCH] [frontend] improve code

Signed-off-by: Marine LM <marine.lemezo@filigran.io>
---
 .../simulations/simulation/overview/Exercise.tsx    |  2 +-
 .../simulation/reports/ExerciseReportContent.tsx    | 13 +++++++------
 2 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/openbas-front/src/admin/components/simulations/simulation/overview/Exercise.tsx b/openbas-front/src/admin/components/simulations/simulation/overview/Exercise.tsx
index c4e2680d70..648375a41b 100644
--- a/openbas-front/src/admin/components/simulations/simulation/overview/Exercise.tsx
+++ b/openbas-front/src/admin/components/simulations/simulation/overview/Exercise.tsx
@@ -102,7 +102,7 @@ const Exercise = () => {
         {exercise.exercise_status !== 'SCHEDULED' && (
           <Grid item xs={12} style={{ marginTop: 25 }}>
             <Typography variant="h4" gutterBottom style={{ marginBottom: 15 }}>
-              {t('Injects Results')}
+              {t('Injects results')}
             </Typography>
             <Paper classes={{ root: classes.paper }} variant="outlined">
               <InjectDtoList
diff --git a/openbas-front/src/admin/components/simulations/simulation/reports/ExerciseReportContent.tsx b/openbas-front/src/admin/components/simulations/simulation/reports/ExerciseReportContent.tsx
index a3ad651837..f88943af4b 100644
--- a/openbas-front/src/admin/components/simulations/simulation/reports/ExerciseReportContent.tsx
+++ b/openbas-front/src/admin/components/simulations/simulation/reports/ExerciseReportContent.tsx
@@ -39,6 +39,12 @@ const ExerciseReportContent: React.FC<Props> = ({ report, exerciseId, canWrite =
   const [loading, setLoading] = useState(true);
   const globalObservationRef = useRef<string>(report?.report_global_observation ?? '');
 
+  const saveGlobalObservation = () => updateReportGlobalObservation(exerciseId, report.report_id, {
+    report_informations: report.report_informations,
+    report_global_observation: globalObservationRef.current,
+    report_name: report.report_name,
+  } as ReportInput);
+
   const displayModule = (moduleType: ReportInformationType) => {
     return report?.report_informations?.find((info: ReportInformation) => info.report_informations_type === moduleType)?.report_informations_display;
   };
@@ -145,12 +151,7 @@ const ExerciseReportContent: React.FC<Props> = ({ report, exerciseId, canWrite =
                     globalObservationRef.current = value;
                   }}
                   style={{ height: 200, width: '100%' }}
-                  onBlur={() => updateReportGlobalObservation(exerciseId, report.report_id, {
-                    report_informations: report.report_informations,
-                    report_global_observation: globalObservationRef.current,
-                    report_name: report.report_name,
-                  } as ReportInput)
-                }
+                  onBlur={saveGlobalObservation}
                 /> : <Paper variant="outlined" sx={{ padding: '10px 15px 10px 15px' }}>
                   {globalObservationRef.current
                     ? <div dangerouslySetInnerHTML={{ __html: globalObservationRef.current }}/>