Code Refactoring (With new test cases) #16994
Conversation
|
I have added this test cases to cover some edge case which were not being checked for smoother functioning. |
|
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
|
How can I add my name/email to the commit ?
…On Mon, Nov 6, 2023, 12:05 AM William Cheng ***@***.***> wrote:
Thanks for the PR but your commit (as shown in the Commits tab) is not
linked to your Github account, which means this PR won't count as your
contribution in
https://github.com/OpenAPITools/openapi-generator/graphs/contributors.
Let me know if you need help fixing it.
Ref:
https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account
—
Reply to this email directly, view it on GitHub
<#16994 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKS2IJ4LPVZ4GZVPR3UFKXLYDBOXNAVCNFSM6AAAAAA66U2CV2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJUGA2TCMRUGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I have added my email to the account. |
|
If still any fix is needed please tell me I will do it. |
| birdAndCategory.setSize("Small"); | ||
| assertEquals("Small", birdAndCategory.getSize()); | ||
|
|
||
| birdAndCategory.setSize("Large"); |
There was a problem hiding this comment.
should be model instead of birdAndCategory ?
same for line 37
There was a problem hiding this comment.
Yeah let me change and push it.
|
Have Pushed the required changes. |
|
a different error: https://github.com/OpenAPITools/openapi-generator/actions/runs/6779625993/job/18428069487?pr=16994 can you please run the the test locally to confirm the fix? |
|
Yes will do before next push, sorry about that. |
MANN3005
changed the title
new tests: workflow, java, android, javascript