From 44ae981830b53acc8019ebae9f4b9acfdba1a520 Mon Sep 17 00:00:00 2001 From: Bijan Chokoufe Nejad Date: Thu, 11 Apr 2024 04:45:41 +0200 Subject: [PATCH] Update versions for typescript-node and remove vulnerable test package (#18334) * Update versions for typescript-node Use latest versions for `bluebird` and `request` and remove `rewire`. `rewire` has high security alerts and shouldn't have been added to the generated clients as its used in tests. It was introduced here https://github.com/OpenAPITools/openapi-generator/commit/960412a9b4b60c597ebab5b11871b5848f5c97cb#diff-1df884eca4890fc2cff7eec6f61ac2157b1b9e72fe4cc13c782e300125fb0da3R20 although the same commit shows that it used to work without it https://github.com/OpenAPITools/openapi-generator/commit/960412a9b4b60c597ebab5b11871b5848f5c97cb#diff-d2785da28187b6d6ef1e0bdab42139309e443906fb5d9d365fce5e2a01673ef5R52-R56 * Update Typescript sample --- .../src/main/resources/typescript-node/package.mustache | 5 ++--- samples/client/petstore/typescript-node/npm/package.json | 5 ++--- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/modules/openapi-generator/src/main/resources/typescript-node/package.mustache b/modules/openapi-generator/src/main/resources/typescript-node/package.mustache index d013eab0374e..b9dc19c81a7a 100644 --- a/modules/openapi-generator/src/main/resources/typescript-node/package.mustache +++ b/modules/openapi-generator/src/main/resources/typescript-node/package.mustache @@ -16,9 +16,8 @@ "author": "OpenAPI-Generator Contributors", "license": "Unlicense", "dependencies": { - "bluebird": "^3.5.0", - "request": "^2.81.0", - "rewire": "^3.0.2" + "bluebird": "^3.7.2", + "request": "^2.88.2" }, "devDependencies": { "@types/bluebird": "^3.5.33", diff --git a/samples/client/petstore/typescript-node/npm/package.json b/samples/client/petstore/typescript-node/npm/package.json index ad36a8f82955..5f9c28d342d8 100644 --- a/samples/client/petstore/typescript-node/npm/package.json +++ b/samples/client/petstore/typescript-node/npm/package.json @@ -16,9 +16,8 @@ "author": "OpenAPI-Generator Contributors", "license": "Unlicense", "dependencies": { - "bluebird": "^3.5.0", - "request": "^2.81.0", - "rewire": "^3.0.2" + "bluebird": "^3.7.2", + "request": "^2.88.2" }, "devDependencies": { "@types/bluebird": "^3.5.33",