Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narrow the matching of the saml metadata route #2077

Open
matrss opened this issue Nov 7, 2023 · 1 comment
Open

Narrow the matching of the saml metadata route #2077

matrss opened this issue Nov 7, 2023 · 1 comment
Labels
mscolab SAML2 feature of 9.0 improvements

Comments

@matrss
Copy link
Collaborator

matrss commented Nov 7, 2023

@APP.route("/metadata/<idp_identity_name>", methods=['GET'])

This route could also be defined in a loop for each IdP (similar to the acs_post_handler), so that it does not match too broadly. That would remove the requirement for an explicit 404 (and the need for the entire 404 template).

Originally posted by @matrss in #2069 (comment)

@matrss matrss added the SAML2 feature of 9.0 improvements label Nov 7, 2023
@matrss
Copy link
Collaborator Author

matrss commented Nov 7, 2023

Even better, use the (very sparsely documented) any route converter. That way, the function can stay as is and only the route matching string has to be modified.

References:

@matrss matrss changed the title Narrow the matching of the saml metadata Narrow the matching of the saml metadata route Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mscolab SAML2 feature of 9.0 improvements
Projects
None yet
Development

No branches or pull requests

2 participants