Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make VERIFY_SSL_CERT config name more descriptive #2073

Closed
matrss opened this issue Nov 7, 2023 · 1 comment · Fixed by #2094
Closed

Make VERIFY_SSL_CERT config name more descriptive #2073

matrss opened this issue Nov 7, 2023 · 1 comment · Fixed by #2094
Assignees
@nilupulmanodya
Labels
SAML2 feature of 9.0 improvements

Comments

@matrss
Copy link
Collaborator

matrss commented Nov 7, 2023

MSS/mslib/mscolab/conf.py

Line 121 in f6b3ad1

VERIFY_SSL_CERT = True

This config option name should somehow make clear that it only applies to the certificates used between MSColab as a SAML SP and the IdP, nothing else.

Originally posted by @matrss in #2069 (comment)
@matrss matrss added the SAML2 feature of 9.0 improvements label Nov 7, 2023
@nilupulmanodya
Copy link
Collaborator

@matrss I want to work on this, please assign me

@nilupulmanodya nilupulmanodya mentioned this issue Nov 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nilupulmanodya nilupulmanodya

Labels
SAML2 feature of 9.0 improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

improve clarity VERIFY_SSL_CERT config option nilupulmanodya/MSS
2 participants
@matrss @nilupulmanodya