Skip to content

Commit 38d98f5

Browse files
committed
WIP
1 parent c51cea4 commit 38d98f5

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

openeo_driver/datacube.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -624,18 +624,21 @@ def apply_dimension(
624624
context: Optional[dict] = None,
625625
env: EvalEnv,
626626
) -> "DriverVectorCube":
627+
# Is callback a single run_udf node process?
627628
single_run_udf = SingleRunUDFProcessGraph.parse_or_none(process)
628629

629630
if single_run_udf:
630631
# Process with single "run_udf" node
631632
# TODO: check provided dimension with actual dimension of the cube
633+
# TODO: also support along geometries dim (e.g. when it's the only dim)?
632634
if dimension in (self.DIM_BANDS, self.DIM_PROPERTIES) and target_dimension is None:
633635
log.warning(
634636
f"Using experimental feature: DriverVectorCube.apply_dimension along dim {dimension} and empty cube"
635637
)
636-
# TODO: this is non-standard special case: vector cube with only geometries, but no "cube" data
638+
# TODO: data chunking (e.g. large feature collections)
637639
gdf = self._as_geopandas_df()
638640
feature_collection = openeo.udf.FeatureCollection(id="_", data=gdf)
641+
# TODO: dedicated UDF signature to indicate to work on vector cube through a feature collection based API
639642
udf_data = openeo.udf.UdfData(
640643
proj={"EPSG": self._geometries.crs.to_epsg()},
641644
feature_collection_list=[feature_collection],

0 commit comments

Comments
 (0)