Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cbuild-idx] Invalid schema definition #1207

Closed
acabarbaye opened this issue Nov 15, 2023 · 4 comments
Closed

[cbuild-idx] Invalid schema definition #1207

acabarbaye opened this issue Nov 15, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@acabarbaye
Copy link

acabarbaye commented Nov 15, 2023

The schema for the cbuild-idx seems to be invalid as it requires a field build-idx which is not defined in the schema.
Generated index file however, comprises this field :
e.g.

 build-idx:
  generated-by: csolution version 2.1.0
  csolution: hello.csolution.yml
  cprojects:
    - cproject: hello.cproject.yml
  cbuilds:
    - cbuild: hello.Debug+B-U585I-IOT02A.cbuild.yml
      project: hello
      configuration: .Debug+B-U585I-IOT02A
    - cbuild: hello.Release+B-U585I-IOT02A.cbuild.yml
      project: hello
      configuration: .Release+B-U585I-IOT02A
@acabarbaye acabarbaye added the bug Something isn't working label Nov 15, 2023
@acabarbaye
Copy link
Author

acabarbaye commented Nov 15, 2023

Similarly BuildContextType definition is invalid
https://github.com/Open-CMSIS-Pack/devtools/blob/ab7ac4632896a602b92b0b86a1d1f8b823b64ff1/tools/projmgr/schemas/common.schema.json#L798C6-L798C22
there is no cproject field in the structure and, project and cbuild field should probably both be marked as required

@acabarbaye
Copy link
Author

Moreover, the schema is missing the type definition https://json-schema.org/draft/2020-12/json-schema-core#name-keywords-for-applying-subschemas : There should be "type": "object",

@jkrech
Copy link
Member

jkrech commented Nov 16, 2023

Moreover, the schema is missing the type definition https://json-schema.org/draft/2020-12/json-schema-core#name-keywords-for-applying-subschemas : There should be "type": "object",

see: #1211

@soumeh01
Copy link
Collaborator

Moreover, the schema is missing the type definition https://json-schema.org/draft/2020-12/json-schema-core#name-keywords-for-applying-subschemas : There should be "type": "object",

see: #1211

Already fixed in #1208

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

No branches or pull requests

4 participants