Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do these api (deployNewTitleEscrow) and cli (open-attestation deploy title-escrow) behave the same ? #224

Open
armmarov86 opened this issue Apr 4, 2022 · 4 comments

Comments

@armmarov86
Copy link

Hi, I tried to create a new title escrow using api from node-js. Apparently i called deployNewTitleEscrow api but there is no contract address appear at the receipt. So I want to get some clarification whether can I use the deployNewTitleEscrow api to create new title escrow like "open-attestation deploy title-escrow" or should I use different api ?

@superical
Copy link

I tried to create a new title escrow using api from node-js

Which nodejs API are you referring to?

@armmarov86
Copy link
Author

armmarov86 commented Apr 4, 2022

Hi, thanks for the reply. This is how i did

import { TradeTrustERC721Factory } from "@govtechsg/token-registry"

const connectedRegistry = TradeTrustERC721Factory.connect(
     <TOKEN_REGISTRY_ADDRESS>, 
      <SIGNER_OBJECT>);

const tx = await connectedRegistry.deployNewTitleEscrow(
     <TOKEN_REGISTRY_ADDRESS>,
     <BENEFICIARY_ADDRESS>, 
     <HOLDER_ADDRESS>);

const receipt = await tx.wait();
console.log(receipt);

Please let me know if I'm doing it wrongly. I was expecting to get new title escrow contract address at the receipt but seems like the contract address is null.

@superical
Copy link

This sounds like a question more with the token registry if I understood you correctly? Which version are you using?

@superical
Copy link

Btw, if you are using v3.2, you shouldn't have to create title escrow manually.🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants