diff --git a/src/components/app/AuthenticatedApp.tsx b/src/components/app/AuthenticatedApp.tsx index e36f71e40..be7da6f56 100644 --- a/src/components/app/AuthenticatedApp.tsx +++ b/src/components/app/AuthenticatedApp.tsx @@ -1,5 +1,11 @@ import * as React from 'react'; -import { ComponentType, useContext, useEffect, useState } from 'react'; +import { + ComponentType, + useCallback, + useContext, + useEffect, + useState +} from 'react'; import { Routing } from './Routing'; import { config } from '../../resources/scripts/config'; import { @@ -35,7 +41,11 @@ interface AuthenticatedAppProps { legalComponent: ComponentType; } -export const AuthenticatedApp = (props: AuthenticatedAppProps) => { +export const AuthenticatedApp = ({ + onLogout, + onAppReady, + legalComponent +}: AuthenticatedAppProps) => { const { setConsultingTypes } = useContext(ConsultingTypesContext); const { setAuthData } = useContext(AuthDataContext); const [authDataRequested, setAuthDataRequested] = useState(false); @@ -44,6 +54,7 @@ export const AuthenticatedApp = (props: AuthenticatedAppProps) => { const [userDataRequested, setUserDataRequested] = useState(false); const { notifications } = useContext(NotificationsContext); const { sessionsData } = useContext(SessionsDataContext); + const sessionId = sessionsData?.mySessions?.[0]?.session?.id; if (!authDataRequested) { setAuthDataRequested(true); @@ -78,27 +89,25 @@ export const AuthenticatedApp = (props: AuthenticatedAppProps) => { } useEffect(() => { - props.onAppReady(); + onAppReady(); }, [appReady]); // eslint-disable-line react-hooks/exhaustive-deps - const handleLogout = () => { + const handleLogout = useCallback(() => { if (hasUserAuthority(AUTHORITIES.ANONYMOUS_DEFAULT, userData)) { - apiFinishAnonymousConversation( - sessionsData?.mySessions[0].session.id - ).catch((error) => { + apiFinishAnonymousConversation(sessionId).catch((error) => { console.error(error); }); } - props.onLogout(); + onLogout(); logout(); - }; + }, [onLogout, sessionId, userData]); if (appReady) { return ( <> {notifications && ( diff --git a/src/components/app/Routing.tsx b/src/components/app/Routing.tsx index 933ed3edb..c287fbe12 100644 --- a/src/components/app/Routing.tsx +++ b/src/components/app/Routing.tsx @@ -31,6 +31,8 @@ interface routingProps { export const Routing = (props: routingProps) => { const { userData } = useContext(UserDataContext); const { sessionsData } = useContext(SessionsDataContext); + const sessionGroupId = sessionsData?.mySessions?.[0]?.session?.groupId; + const sessionId = sessionsData?.mySessions?.[0]?.session?.id; const routerConfig = useMemo(() => { if (hasUserAuthority(AUTHORITIES.VIEW_ALL_PEER_SESSIONS, userData)) { @@ -66,14 +68,13 @@ export const Routing = (props: routingProps) => { // Redirect anonymous live chat users to their one and only session useEffect(() => { if (hasUserAuthority(AUTHORITIES.ANONYMOUS_DEFAULT, userData)) { - const groupId = sessionsData?.mySessions[0].session.groupId; - const id = sessionsData?.mySessions[0].session.id; - - if (groupId && id) { - history.push(`/sessions/user/view/${groupId}/${id}`); + if (sessionGroupId && sessionId) { + history.push( + `/sessions/user/view/${sessionGroupId}/${sessionId}` + ); } } - }, [sessionsData, userData]); + }, [sessionGroupId, sessionId, userData]); return (
@@ -85,40 +86,32 @@ export const Routing = (props: routingProps) => {
- {useMemo( - () => - routerConfig.listRoutes.map( - (route: any, index: any): JSX.Element => ( - - ) - ), - [routerConfig.listRoutes] + {routerConfig.listRoutes.map( + (route: any): JSX.Element => ( + + ) )}
- {useMemo( - () => - routerConfig.detailRoutes.map( - (route: any, index: any): JSX.Element => ( - ( - - )} + {routerConfig.detailRoutes.map( + (route: any): JSX.Element => ( + ( + - ) - ), - [routerConfig.detailRoutes, props] + )} + /> + ) )} {((hasUserProfileRoutes) => { @@ -126,15 +119,12 @@ export const Routing = (props: routingProps) => { return (
{routerConfig.userProfileRoutes.map( - ( - route: any, - index: any - ): JSX.Element => ( + (route: any): JSX.Element => ( ( + render={(props) => ( {
- {useMemo( - () => - routerConfig.profileRoutes?.map( - (route: any, index: any): JSX.Element => ( - ( - - )} + {routerConfig.profileRoutes?.map( + (route: any): JSX.Element => ( + ( + - ) - ), - [routerConfig.profileRoutes, props] + )} + /> + ) )}