Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: lint warning regarding PluginRegistry Depreciation #639

Closed
2 of 3 tasks
christopherowen opened this issue Jan 30, 2023 · 1 comment
Closed
2 of 3 tasks

[BUG]: lint warning regarding PluginRegistry Depreciation #639

christopherowen opened this issue Jan 30, 2023 · 1 comment

Comments

@christopherowen
Copy link

christopherowen commented Jan 30, 2023

What happened?

I'm receiving this error on release build with lint enabled:

/opt/homebrew/Caskroom/flutter/3.7.0/flutter/.pub-cache/hosted/pub.dev/onesignal_flutter-3.5.0/android/src/main/java/com/onesignal/flutter/OneSignalOutcomeEventsController.java:15: warning: [deprecation] Registrar in PluginRegistry has been deprecated
import io.flutter.plugin.common.PluginRegistry.Registrar;
                                              ^
/opt/homebrew/Caskroom/flutter/3.7.0/flutter/.pub-cache/hosted/pub.dev/onesignal_flutter-3.5.0/android/src/main/java/com/onesignal/flutter/OneSignalPlugin.java:42: warning: [deprecation] Registrar in PluginRegistry has been deprecated
import io.flutter.plugin.common.PluginRegistry.Registrar;
                                              ^
/opt/homebrew/Caskroom/flutter/3.7.0/flutter/.pub-cache/hosted/pub.dev/onesignal_flutter-3.5.0/android/src/main/java/com/onesignal/flutter/OneSignalPlugin.java:43: warning: [deprecation] FlutterNativeView in io.flutter.view has been deprecated
import io.flutter.view.FlutterNativeView;
                      ^
/opt/homebrew/Caskroom/flutter/3.7.0/flutter/.pub-cache/hosted/pub.dev/onesignal_flutter-3.5.0/android/src/main/java/com/onesignal/flutter/OneSignalTagsController.java:20: warning: [deprecation] Registrar in PluginRegistry has been deprecated
import io.flutter.plugin.common.PluginRegistry.Registrar;
                                              ^
/opt/homebrew/Caskroom/flutter/3.7.0/flutter/.pub-cache/hosted/pub.dev/onesignal_flutter-3.5.0/android/src/main/java/com/onesignal/flutter/OneSignalInAppMessagingController.java:13: warning: [deprecation] Registrar in PluginRegistry has been deprecated
import io.flutter.plugin.common.PluginRegistry.Registrar;
                                              ^
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

Steps to reproduce?

1. build a flutter project using onesignal with lint enabled

What did you expect to happen?

No lint warnings.

My searching on the topic lead me to this page, but I'm a little out of my depth:

https://api.flutter.dev/javadoc/io/flutter/plugin/common/PluginRegistry.html
https://docs.flutter.dev/development/platform-integration/android/plugin-api-migration

OneSignal Flutter SDK version

Release 3.5.0

Which platform(s) are affected?

  • iOS
  • Android

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@nan-li
Copy link
Contributor

nan-li commented Oct 24, 2024

Hi, we have had no further reports of this. Please upgrade the OneSignal SDK if you or anyone is still having this issue. If this is still an issue, please open a new report with updated information.

@nan-li nan-li closed this as completed Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants