-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix linting errors in GitHub Actions build test workflow #1882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes from running ktlintFormat
remove wildcard imports
address linting error that enforces camel case
address linting errors that enforce camel case and prohibits leading underscore
address linting error that enforces camel case/screaming snake case & disallows backticks
address linting error that enforces camel case and screaming snake case
emawby
suggested changes
Oct 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Have we done any functional testing with these changes to validate things build and run as expected?
Yes! Updating PR comment with functional testing results. |
emawby
approved these changes
Oct 26, 2023
This was referenced Nov 2, 2023
Merged
jinliu9508
pushed a commit
that referenced
this pull request
Jan 31, 2024
Fix linting errors in GitHub Actions build test workflow
jinliu9508
pushed a commit
that referenced
this pull request
Jan 31, 2024
Fix linting errors in GitHub Actions build test workflow
jinliu9508
pushed a commit
that referenced
this pull request
Feb 6, 2024
Fix linting errors in GitHub Actions build test workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Fix linting errors in GitHub Actions build test workflow
Details
Motivation
New PRs were failing the GitHub Actions build test due to linting errors.
Steps to fix the issue:
ktlint
pluginorg.jlleitschuh.gradle.ktlint
to latest version (11.6.1)./gradlew ktlintFormat
to auto-fix errorsThe errors that were manually fixed included these
ktlint
rules:max-line-length
: increased to 500 inktlint
build.gradle configuration blocks (all modules)property-naming
: replaced certain property names with camel case and screaming snake case according to Kotlin rulesScope
All modules of OneSignal were impacted:
Testing
Manual testing
Final run of
./gradlew ktlintCheck --console=plain
pass with no additional errors. Example app successfully builds and runs with no errors.Functionally tested the following actions in example app to ensure no issues:
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is