Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List view show nudge action doesn't work #401

Open
ualch9 opened this issue Jun 24, 2021 · 0 comments
Open

List view show nudge action doesn't work #401

ualch9 opened this issue Jun 24, 2021 · 0 comments

Comments

@ualch9
Copy link
Member

ualch9 commented Jun 24, 2021 •
edited
Loading

https://github.com/OneBusAway/OBAKit/blob/2d605ee009f5a727dd5ad0b9b7809308b39be5a9/OBAKit/Stops/Sections/StopArrival/StopArrivalCell.swift#L67-L70

Originally posted by @aaronbrethorst in #391 (comment)
@ualch9 ualch9 mentioned this issue Jun 24, 2021
Merged
ualch9 added a commit to ualch9/onebusaway-ios that referenced this issue Jun 26, 2021
@ualch9
Fixes list view’s didApplyData delegate regression
f73264b 
Temporaily disables arrival nudge message (OneBusAway#401)
ualch9 added a commit to ualch9/onebusaway-ios that referenced this issue Jun 28, 2021
@ualch9
Squashed commit of the following:
0d1b575 
commit f73264b
Author: Alan Chu <[email protected]>
Date:   Sat Jun 26 15:08:18 2021 -0700

    Fixes list view’s didApplyData delegate regression

    Temporaily disables arrival nudge message (OneBusAway#401)

commit 7956321
Author: Alan Chu <[email protected]>
Date:   Sat Jun 26 10:39:35 2021 -0700

    Deselects cells after being selected in OBAListView

    Fixes OneBusAway#399 — List view cells appears selected after presenting/pushing view controller

commit eab68e2
Author: Alan Chu <[email protected]>
Date:   Sat Jun 26 10:41:52 2021 -0700

    Adopt sectionSnapshotHandlers for section collapse state in OBAListView

    Fixes OneBusAway#392 — Collapsed sections not notifying delegate or saving state

commit 27a6200
Author: Alan Chu <[email protected]>
Date:   Sat Jun 26 10:03:29 2021 -0700

    Fixes recent stops item ordering

    Fixes OneBusAway#390 — Inconsistent recent stops ordering
@aaronbrethorst aaronbrethorst added this to the Post-Launch milestone Jul 8, 2021
@aaronbrethorst aaronbrethorst removed this from the Post-Launch milestone Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aaronbrethorst @ualch9