Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List view separators always appears on iOS 14.4 #398

Closed
ualch9 opened this issue Jun 23, 2021 · 0 comments · Fixed by #486
Closed

List view separators always appears on iOS 14.4 #398

ualch9 opened this issue Jun 23, 2021 · 0 comments · Fixed by #486
Assignees
@aaronbrethorst
Milestone
v21.2

Comments

@ualch9
Copy link
Member

ualch9 commented Jun 23, 2021

CI downgraded to 14.4 for compatibility, #397.

@aaronbrethorst im using https://developer.apple.com/documentation/uikit/uicollectionlayoutlistconfiguration/3727738-separatorconfiguration in #391. Not a logic feature, only for visuals. I believe this is the only 14.5-specific feature I'm currently using, so I can remove it from 14.4 if necessary? -- #397 (comment)
ualch9 added a commit to ualch9/onebusaway-ios that referenced this issue Jun 23, 2021
@ualch9
Add version check for iOS 14.5 API
eb9917a 
See OneBusAway#398, added support for iOS 14.4 for CI compatibility.
@ualch9 ualch9 mentioned this issue Jun 23, 2021
Merged
@aaronbrethorst aaronbrethorst added this to the Post-Launch milestone Jul 8, 2021
@ualch9 ualch9 modified the milestones: Post-Launch, v1.1 Aug 7, 2021
aaronbrethorst added a commit that referenced this issue Aug 14, 2021
@aaronbrethorst
Update required OS version to iOS 14.5
2192a06 
Fixes #398 - List view separators always appears on iOS 14.4
@aaronbrethorst aaronbrethorst self-assigned this Aug 14, 2021
@aaronbrethorst aaronbrethorst mentioned this issue Aug 14, 2021
Merged
aaronbrethorst added a commit that referenced this issue Aug 14, 2021
@aaronbrethorst
Update required OS version to iOS 14.5
0688bb8 
Fixes #398 - List view separators always appears on iOS 14.4
aaronbrethorst added a commit that referenced this issue Aug 14, 2021
@aaronbrethorst
Update required OS version to iOS 14.5
dd99d67 
Fixes #398 - List view separators always appears on iOS 14.4
aaronbrethorst added a commit that referenced this issue Aug 14, 2021
@aaronbrethorst
Update CI to use macOS 11/Xcode 12.5
c9b48de 
Fixes #398 - List view separators always appears on iOS 14.4
@aaronbrethorst aaronbrethorst mentioned this issue Aug 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaronbrethorst aaronbrethorst

Labels
None yet
Projects
None yet
Milestone
v21.2
Development

Successfully merging a pull request may close this issue.

Update CI to use macOS 11/Xcode 12.5 OneBusAway/onebusaway-ios
2 participants
@aaronbrethorst @ualch9