Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing or wrong defaultValues for StopTimes #138

Open
hbruch opened this issue Feb 2, 2020 · 0 comments
Open

Missing or wrong defaultValues for StopTimes #138

hbruch opened this issue Feb 2, 2020 · 0 comments
Assignees

Comments

@hbruch
Copy link
Contributor

hbruch commented Feb 2, 2020

Summary:
Various fields in StopTimes.java define no or wrong defaultValues in the CSVField annotation, e.g. for departureBuffer -1 is set as default, but the initialized value is 0. For all fields initialized with MISSING_VALUE, like e.g. endServiceAreaRadius, their string equivalent of -999 should be the defaultValue.

As a result, these fields are written though all values a missing.

Steps to reproduce:
Transform a GTFS feed and open StopTimes.txt. It contains e.g. the column departureBuffer with value 0, though it was unchanged and did not exist in the original feed.

Expected behavior:
No new columns are added without explicitly setting values for these.

Observed behavior:

What happened instead? Describe your issue in detail here.

Platform:
N.A.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants