Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for UTF-8 multi-byte characters and other corner cases #119

Open
msgilligan opened this issue Oct 20, 2015 · 3 comments
Open

Tests for UTF-8 multi-byte characters and other corner cases #119

msgilligan opened this issue Oct 20, 2015 · 3 comments

Comments

@msgilligan
Copy link
Member

It would be nice to have unit tests for OmniJ itself and regtest integration tests for Omni Core.

@dexX7
Copy link
Member

dexX7 commented Oct 26, 2015

We had a bit of trouble with non-UTF8 multibyte strings in Omni Core (see OmniLayer/omnicore#108), and I ended up with sanitizing RPC results.

OmniLayer/omnicore#177 added locale-independent functions to validate and sanitize UTF-8 encoded strings, and it has a bunch of unit tests.

edit: see also my note in OmniLayer/omnicore#177 (comment):

While the validation should be able to handle any UTF-8 encoded string, including foreign character sets, it is unfortunally partially overruled by the sanitization of json_spirit::, which is not locale-independent, and neither supports multibyte character sequences.

In practise this means this PR ensures that no invalid characters slip through (as outlined in 108), but it doesn't imply that Omni Core can display all kinds of characters, which are considered as properly encoded.

@ahmedrem55538
Copy link

يجب حذف ماهوا خطاواصلاحة

@ahmedrem55538
Copy link

يجب اصلاح الاخطا تلقائي دون ان يحتاج لمراجعة جهة اخرا

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants