Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stanza (line blocks) not working after the fist verse #133

Open
jodros opened this issue Nov 26, 2024 · 6 comments
Open

Stanza (line blocks) not working after the fist verse #133

jodros opened this issue Nov 26, 2024 · 6 comments
Labels
bug Something isn't working report to Lunamark Issue should be generalized and reported to Lunamark

Comments

@jodros
Copy link

jodros commented Nov 26, 2024

This works:

::: {.poetry}                                                                           
| CANTIGA DE MAL DIZER                                                                                                                      
| Ai, dona fea, fostes-vos queixar                                                                                                          
| que vos nunca louv’ en(o) meu cantar;
:::

This doesn't:

::: {.poetry}                                                                           
| CANTIGA DE MAL DIZER
|                                                                                             
| Ai, dona fea, fostes-vos queixar                                                                                                          
| que vos nunca louv’ en(o) meu cantar;
:::

While stanzas in any other part work fine.

@Omikhleia
Copy link
Owner

What's the result then in the non-working case?

@jodros
Copy link
Author

jodros commented Nov 26, 2024

What's the result then in the non-working case?

image

@Omikhleia
Copy link
Owner

@jodros Eek, that's what I feared... Hmm so I guess it's a markdown parsing bug.

  • We can try to fix it in our own vendored version of the lunamark library
  • But eventually we'll also want it upstream, so we need to craft a lunamark test for it, to prove it's indeed the case.

@Omikhleia
Copy link
Owner

And looking at lunarmark quickly, it might be a tricky issue with | being used both for line-blocks and tables (so there's a parsing ambiguity). Pfeew, nice bug ^^

@Omikhleia Omikhleia added bug Something isn't working report to Lunamark Issue should be generalized and reported to Lunamark labels Nov 26, 2024
@Omikhleia
Copy link
Owner

Workaround with an empty line, this does work apparently:

| 
| Blah
|
| Lorem ipsum

(Hence, it does point to a bug in the parsing library)

@Omikhleia Omikhleia changed the title Stanza not working after the fist verse Stanza (line blocks) not working after the fist verse Nov 26, 2024
@Omikhleia
Copy link
Owner

Reported: jgm/lunamark#83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working report to Lunamark Issue should be generalized and reported to Lunamark
Projects
None yet
Development

No branches or pull requests

2 participants