Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling messages for feedrate changes to improve performance #284

Open
MiK1977 opened this issue Mar 12, 2024 · 1 comment
Open

Comments

@MiK1977
Copy link

MiK1977 commented Mar 12, 2024

I have problems like in Issue #124.

It seems to occur when the gcode has many flowrate changes.

I commented out this section:

    # feedrate
    matched = feedratePattern.match(commandAsString)
    if matched:
        feedrate = matched.group(1)
        self._feedrate = feedrate
        if commandAsString.startswith('G0'):
            self._feedrateG0 = feedrate
        if commandAsString.startswith('G1'):
            self._feedrateG1 = feedrate
        self._updateDisplay(UPDATE_DISPLAY_REASON_FEEDRATE_CHANGED)

In the result the prints were flawless.

Could you please add a possibility to disable reacting on feedrate changes?

@hyperair
Copy link

hyperair commented Jun 24, 2024

+1, it seems like PrusaSlicer has been generating many feedrate changes for me as well, either due to Arachne perimeter generation, perimeter autospeed, or dynamic overhang speeds, and I've been needing to resort to printing from Klipper's virtual sdcard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants