"Misconfigured" NAA request can crash to desktop in New Outlook

[barclayadam]

Provide required information needed to triage your issue

Similar to the bug report in #5209 if an NAA token is requested that only specifies profile and openid New Outlook for Windows will hard crash.

Based on the other issue my calls are "misconfigured", which I still want to understand more so I've added some new comments to it, but it should not be this easy to crash to desktop.

Given the pain and number of issues with NAA, I have very little confidence with going live with this, that we will not be inundated with issues from our customers. With the February legacy token cut-off date looming I'm very concerned about the quality of implementation across the different Outlook clients.

Your Environment

• Platform [PC desktop, Mac, iOS, Office on the web]: PC Desktop - New Outlook
• Host [Excel, Word, PowerPoint, etc.]: Outlook
• Office version number: 1.2024.1216.300 (Production).
• Client Version is 20241213002.09.
• WebView2 Version is 131.0.2903.112
• Operating System: Windows 11

Expected behavior

Outlook to at least not crash to desktop.

Current behavior

If requesting only profile and openid scopes Outlook crashes to desktopIn Event Viewer I see:

Faulting application name: olk.exe, version: 1.2024.1216.300, time stamp: 0x6760e896
Faulting module name: nh-mod-auth.dll, version: 0.0.0.0, time stamp: 0x6760e89b
Exception code: 0xc0000005
Fault offset: 0x0000000000182f65
Faulting process id: 0x0x7D60
Faulting application start time: 0x0x1DB633F3298A3B9
Faulting application path: C:\Program Files\WindowsApps\Microsoft.OutlookForWindows_1.2024.1216.300_x64__8wekyb3d8bbwe\olk.exe
Faulting module path: C:\Program Files\WindowsApps\Microsoft.OutlookForWindows_1.2024.1216.300_x64__8wekyb3d8bbwe\modules\nh-mod-auth\nh-mod-auth.dll
Report Id: 2d50f3a4-6fca-4e63-acb2-be0b6a85008a
Faulting package full name: Microsoft.OutlookForWindows_1.2024.1216.300_x64__8wekyb3d8bbwe
Faulting package-relative application ID: Microsoft.OutlookforWindows

Fault bucket 2186389539039937283, type 5
Event Name: MoAppCrash
Response: Not available
Cab Id: 0

Problem signature:
P1: Microsoft.OutlookForWindows_1.2024.1216.300_x64__8wekyb3d8bbwe
P2: praid:Microsoft.OutlookforWindows
P3: 1.2024.1216.300
P4: 6760e896
P5: nh-mod-auth.dll
P6: 0.0.0.0
P7: 6760e89b
P8: c0000005
P9: 0000000000182f65
P10: 

Attached files:
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER.2efd3c4d-e62d-41cf-8a8a-62f2b83809a7.tmp.mdmp
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER.106384d1-c78f-4c8e-a005-42b1d23affe1.tmp.WERInternalMetadata.xml
WPR_initiated_DiagTrackMiniLogger_OneTrace_User_Logger_20241008_1_EC_0_inject.etl
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER.a90ec4c4-00b2-4e8c-a815-a477c7012a7b.tmp.etl
WPR_initiated_DiagTrackMiniLogger_WPR System Collector_inject.etl
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER.58c84560-c966-4740-be3b-9a76664e3d69.tmp.etl
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER.068baeb5-05c3-4e8f-aa14-ef817b269775.tmp.csv
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER.57064c17-d729-4ef9-9350-d48633295fc3.tmp.txt
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER.5877ec96-2ace-4d25-904c-8534f40f8b57.tmp.xml

These files may be available here:
\\?\C:\ProgramData\Microsoft\Windows\WER\ReportArchive\AppCrash_Microsoft.Outloo_dbc86597f64650e290d88271bd28bf16d647370_d6c2f83d_4dd07121-b177-45d4-b99f-044346a11f72

Analysis symbol: 
Rechecking for solution: 0
Report Id: 2d50f3a4-6fca-4e63-acb2-be0b6a85008a
Report Status: 268435456
Hashed bucket: f52d377843b186cace579db3a71b0303
Cab Guid: 0

Steps to reproduce

See issue #5209

Thank you for taking the time to report an issue. Our triage team will respond to you in less than 72 hours. Normally, response time is <10 hours Monday through Friday. We do not triage on weekends.

[davidchesnut]

@codexeon can you please take a look at this issue? Thanks!