Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory Edge Cases #230

Merged
merged 6 commits into from
May 3, 2024
Merged

Memory Edge Cases #230

merged 6 commits into from
May 3, 2024

Conversation

rachel-bousfield
Copy link
Contributor

This PR tweaks our policy for fixed-size memories.

  • Adds a test for fixed size memories
  • Fixes the (redundant) user-host Program::check_memory_access
  • Moves more of the cost into the actual opcode

@cla-bot cla-bot bot added the s label Apr 18, 2024
Base automatically changed from wasmer-v4.2.8 to stylus April 30, 2024 04:51
@rachel-bousfield rachel-bousfield changed the base branch from stylus to stylus-nitro-conflicts May 3, 2024 06:31
@rachel-bousfield rachel-bousfield merged commit 85f4571 into stylus-nitro-conflicts May 3, 2024
7 of 8 checks passed
@rachel-bousfield rachel-bousfield deleted the fixed-memory-edge-case branch May 3, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rachel-bousfield