You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Your recent change to the TypeRegistry allowing polymorphism is a great addition, but we find its contraints a bit too limiting.
The current implementation requires types to be either abstract or interefaces in order to pick up derived types, but this is not always feasible. My suggestion is to introduce a HalibutPolymorphicAttribute and optionally HalibutDerivedTypeAttribute similar to how microsoft did it with System.Text.Json
The text was updated successfully, but these errors were encountered:
Your recent change to the
TypeRegistry
allowing polymorphism is a great addition, but we find its contraints a bit too limiting.The current implementation requires types to be either
abstract
orinterefaces
in order to pick up derived types, but this is not always feasible. My suggestion is to introduce aHalibutPolymorphicAttribute
and optionallyHalibutDerivedTypeAttribute
similar to how microsoft did it with System.Text.JsonThe text was updated successfully, but these errors were encountered: