Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests failing due to Goerli dependency #149

Open
pinebit opened this issue Jan 7, 2025 · 0 comments
Open

Tests failing due to Goerli dependency #149

pinebit opened this issue Jan 7, 2025 · 0 comments
Assignees
@pinebit
Labels
bug Something isn't working contracts

Comments

@pinebit
Copy link
Contributor

pinebit commented Jan 7, 2025

Describe the bug

The tests running with forge test and with CI shall not fail.
Currently some tests fail because they rely on a real Goerli RPC.

To Reproduce
Steps to reproduce the behavior:

  1. Update .env (try placing Sepolia instead of Goerli)
  2. Run 'forge test'
  3. See some tests failing (also in CI - see recent RPs)

Expected behavior
All tests must be passing using actual networks.
@pinebit pinebit self-assigned this Jan 7, 2025
@pinebit pinebit added the bug Something isn't working label Jan 7, 2025
@pinebit pinebit mentioned this issue Jan 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pinebit pinebit

Labels
bug Something isn't working contracts
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pinebit