Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle smart contract wallets in validateClusterLock() #67

Open
1 task
OisinKyne opened this issue Jan 14, 2025 · 0 comments
Open
1 task

Handle smart contract wallets in validateClusterLock() #67

OisinKyne opened this issue Jan 14, 2025 · 0 comments
Assignees
Labels
api-squad bug Something isn't working

Comments

@OisinKyne
Copy link
Contributor

OisinKyne commented Jan 14, 2025

🎯 Problem to be solved

Identified while talking to the Byzantine team. The client.validateClusterLock() method fails for EIP1271 smart contract signatures in the operator field of a cluster lock.

🛠️ Proposed solution

Potentially if a signature fails a normal check we can try a 1271 check? It would be quite heavy on reads of the chain if there are a lot of them, so we wouldn't want to do it by default ideally.

🧪 Tests

  • Netlify deployment build tests passing

👐 Additional acceptance criteria

❌ Out of Scope

Can create a separate issue to use this change in Obol API

@LukeHackett12 LukeHackett12 added the bug Something isn't working label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-squad bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants