Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working with Proxy Serrvers #32

Open
jmahmood opened this issue Apr 11, 2016 · 1 comment
Open

Working with Proxy Serrvers #32

jmahmood opened this issue Apr 11, 2016 · 1 comment
Labels
Milestone

Comments

@jmahmood
Copy link

The system does not work with corporate proxy servers; it hangs Sublime Text until I turn off the wifi (after which it says that the connection is unreachable).

I believe the issue is in the retrieve.py file; the issue may not be that easy to resolve, as it seems that urllib does not handle HTTPS proxies (which is necessary since all the links you have use HTTPS).

Adding the ability to set the proxy in the settings file would be a great first step though. You could then use the code below to set the proxy on the connection.

proxy_support = urllib.request.ProxyHandler({})
opener = urllib.request.build_opener(proxy_support)
urllib.request.install_opener(opener)

@Oblongmana Oblongmana added the bug label Apr 16, 2016
@Oblongmana
Copy link
Owner

Oblongmana commented Apr 16, 2016

Thank you for the report @jmahmood - I'm not likely to be able to work on this in the near future, but would definitely welcome a Pull Request from you if you have the time. Otherwise will try to pick this up in a few weeks.

I am planning on switching to the requests library soon, I believe it's generally considered superior to urllib and urllib2, which I'm inclined to believe given how easy it was to use the last time I played with it. Can be a bit of a pain including 3rd party libs in sublime plugins however. Dropping this link here for my future reference: http://docs.python-requests.org/en/latest/user/advanced/#proxies

@Oblongmana Oblongmana added this to the 2.2.0 milestone Apr 16, 2016
@Oblongmana Oblongmana modified the milestones: 2.2.0, 2.3.0 Jun 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants