Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Specification] Industry Codes table refactor #196

Open
4 tasks
johcarter opened this issue Jun 20, 2024 · 1 comment
Open
4 tasks

[Specification] Industry Codes table refactor #196

johcarter opened this issue Jun 20, 2024 · 1 comment
Assignees
@johcarter
Labels
minor minor release (non-breaking change)

Comments

@johcarter
Copy link
Contributor

Description

  • Removed spaces in scheme names in industry codes table to align with enumerated values in OtherValues tab (eg US SIC --> USSIC)
  • Put all schemes in one long table rather than three separate tables

Reasons for change

Consistency of industry scheme names in specification, and consolidate code lists to make them more machine-readable

Scope of change

Specification

  • Location File
  • Accounts File
  • Reinsurance Scope
  • Reinsurance Info

Impact of change

None
@johcarter johcarter added the minor minor release (non-breaking change) label Jun 20, 2024
@johcarter johcarter self-assigned this Jun 20, 2024
johcarter added a commit that referenced this issue Jun 26, 2024
@johcarter
#196 added table
d1ed972
@MattDonovan82
Copy link
Contributor

Nothing further to add here. Moving to done.

sambles pushed a commit that referenced this issue Jul 17, 2024
@johcarter @sambles
#196 added table
442f1f2
@johcarter johcarter mentioned this issue Aug 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johcarter johcarter

Labels
minor minor release (non-breaking change)
Projects
OED 4.0.0
Status: Done
Oasis Dev Team Tasks
Status: Todo
Open Data Standards
Status: Agreed and ready
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johcarter @MattDonovan82