Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Property] OED fields update for offshore assets modelling #191

Open
1 task
jm-moratalla opened this issue Jun 19, 2024 · 6 comments
Open
1 task

[Property] OED fields update for offshore assets modelling #191

jm-moratalla opened this issue Jun 19, 2024 · 6 comments
Assignees
Labels
major major release (breaking change)

Comments

@jm-moratalla
Copy link

Description

We are proposing updates to the OED schema, to allow for coding of offshore renewable assets.
See attached .xlsx for proposed changes.
Cells highlighted yellow, have been edited/added from the original schema.
Unedited rows/tabs have been removed for clarity.

Reasons for change

To allow for coding of offshore renewable assets.

Scope of change

Changes proposed to:

  • Location File

Impact of change

  • We have updated some offshore FoundationType names and descriptions
  • Also, for including liquefaction effects in the calculations, we have identified the need of a new field (SoilLiquefiable), which determines whether the soil is susceptible to liquefaction or not. Description of how this is determined are included in the notes of the attached.
    These changes should only impact models by Renew-Risk, as other models do not yet use the proposed codings, to our knowledge.

Data type, default values, are blanks allowed, list valid values

See attached .xlsx for proposal.
OpenExposureData_Spec-RenewRisk Proposal 240618.xlsx

@johcarter johcarter self-assigned this Jun 19, 2024
@johcarter johcarter added the minor minor release (non-breaking change) label Jun 19, 2024
@johcarter
Copy link
Contributor

Thanks @jm-moratalla

Have reviewed and have the following comments

  • As you are changing descriptions only and adding a new field and codes, this would be a minor non-breaking change but would go into the next major OED release v4 as that is the next release.
  • You have sent notes for FoundationType 13+, but can you also supply helpful notes for 1-12 which are currently N/A?
  • New field SoilLiquefiable - a few suggestions
  1. Make data type tinyint with default value 0
  2. Make default value 0 mean unknown / or not applicable and shift no and yes to values 1 and 2

Reason for 2: you may not always know if soil is liquefiable or it may not be relevant (for non earthquake locations). If it is unknown then modeller can choose how to map the exposures to vulnerability given the uncertainty.

@johcarter johcarter changed the title OED fields update for offshore assets modelling [Property] OED fields update for offshore assets modelling Jun 19, 2024
@jm-moratalla
Copy link
Author

jm-moratalla commented Jun 20, 2024 via email

@johcarter johcarter added major major release (breaking change) and removed minor minor release (non-breaking change) labels Jun 25, 2024
@johcarter
Copy link
Contributor

Under discussion (new field) fyi @aiste-kalinauskaite

@johcarter
Copy link
Contributor

OpenExposureData_Spec-RenewRisk.Proposal.240618_updated.xlsx

Updated proposal as discussed above. Will be implemented if there are no further comments.

@johcarter
Copy link
Contributor

Implemented version attached

OpenExposureData_Spec-RenewRisk.Proposal.240618_updated2.xlsx

@MattDonovan82
Copy link
Contributor

All looks fine - no additional comments from me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major major release (breaking change)
Projects
Status: Done
Status: Todo
Status: Agreed and ready
Development

No branches or pull requests

3 participants